Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static IP address is not detected if set via /etc/network/interfaces #2302

Closed
ameshkov opened this issue Nov 12, 2020 · 4 comments
Closed

Static IP address is not detected if set via /etc/network/interfaces #2302

ameshkov opened this issue Nov 12, 2020 · 4 comments
Assignees
@EugeneOne1
Labels
feature request P3: Medium
Milestone
v0.105.0

Comments

@ameshkov
Copy link
Member

See the report here:
https://t.me/adguard_en/107079
@ameshkov ameshkov added this to the v0.104.2 milestone Nov 12, 2020
@ainar-g
Copy link
Contributor

ainar-g commented Nov 12, 2020

I can't find any reference to /etc/network/interfaces in the code we have now. Unless I misunderstand something, this is actually a feature request and should thus be in the v0.105.0 milestone. What do you think?

@ameshkov
Copy link
Member Author

Yeah, it should be reassigned to v0.105 indeed.

However, please verify that enabling the DHCP server is possible even when we cannot detect that the IP is static.

@ainar-g
Copy link
Contributor

ainar-g commented Nov 13, 2020

I was able to enable DHCP on a Debian system where we couldn't detect if the IP is static, so I guess this issue should be relabelled as feature request and v0.105.0?

@ameshkov
Copy link
Member Author

Yep

@ainar-g ainar-g modified the milestones: v0.104.2, v0.105 Nov 13, 2020
@ainar-g ainar-g assigned EugeneOne1 and unassigned ainar-g Nov 27, 2020
@adguard adguard closed this as completed in 2313eda Dec 7, 2020
adguard pushed a commit that referenced this issue Dec 10, 2020
@EugeneOne1 @Blakhard
Pull request: 2302 static ip
427364c 
Merge in DNS/adguard-home from 2302-static-ip to master

Closes #2302.

Squashed commit of the following:

commit e62b7b0
Author: Eugene Burkov <[email protected]>
Date:   Mon Dec 7 19:38:15 2020 +0300

    all: format changelog

commit 4127aa7
Author: Eugene Burkov <[email protected]>
Date:   Mon Dec 7 19:24:53 2020 +0300

    all: fix changelog typo

commit f8a4320
Merge: b809a86 e438318
Author: Eugene Burkov <[email protected]>
Date:   Mon Dec 7 19:22:27 2020 +0300

    Merge branch 'master' into 2302-static-ip

commit b809a86
Author: Eugene Burkov <[email protected]>
Date:   Mon Dec 7 19:20:05 2020 +0300

    all: log changes

commit 248c35b
Author: Eugene Burkov <[email protected]>
Date:   Mon Dec 7 18:57:15 2020 +0300

    sysutil: use bufio.Scanner

commit 0dc19dd
Author: Eugene Burkov <[email protected]>
Date:   Mon Dec 7 17:26:18 2020 +0300

    sysutil: fix linux tests

commit 91202d6
Author: Eugene Burkov <[email protected]>
Date:   Mon Dec 7 17:15:29 2020 +0300

    sysutil: fix linux files

commit 40fbdbb
Merge: d9a43ff 9b963fc
Author: Eugene Burkov <[email protected]>
Date:   Mon Dec 7 16:52:35 2020 +0300

    Merge branch 'master' into 2302-static-ip

commit d9a43ff
Author: Eugene Burkov <[email protected]>
Date:   Mon Dec 7 16:49:22 2020 +0300

    sysutil: add main test

commit bfef891
Author: Eugene Burkov <[email protected]>
Date:   Mon Dec 7 16:21:59 2020 +0300

    sysutil: improve code quality

commit a5f57a3
Author: Eugene Burkov <[email protected]>
Date:   Fri Dec 4 14:14:08 2020 +0300

    all: move system functionality from dhcpd package to sysutil.

commit 020b518
Merge: 967e111 ab8defd
Author: Eugene Burkov <[email protected]>
Date:   Wed Dec 2 14:53:43 2020 +0300

    Merge branch 'master' into 2302-static-ip

commit 967e111
Author: Eugene Burkov <[email protected]>
Date:   Wed Dec 2 13:52:17 2020 +0300

    all: improve code quality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
feature request P3: Medium
Projects
None yet
Milestone
v0.105.0
Development

No branches or pull requests
3 participants
@ainar-g @ameshkov @EugeneOne1