Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error with adding static lease #3127

Closed
3 tasks done
pascalwinters opened this issue May 11, 2021 · 3 comments
Closed
3 tasks done

Error with adding static lease #3127

pascalwinters opened this issue May 11, 2021 · 3 comments
Assignees
@ainar-g
Labels
bug P3: Medium
Milestone
v0.106.3

Comments

@pascalwinters
Copy link

pascalwinters commented May 11, 2021 •
edited
Loading

Have a question or an idea? Please search it on our forum to make sure it was not yet asked. If you cannot find what you had in mind, please submit it here.

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

Issue Details

  • Version of AdGuard Home server:
    • v0.106.2
  • How did you install AdGuard Home:
    • Docker

Expected Behavior

DHCP leases would get added.

Actual Behavior

DHCP leases aren't getting added...

Screenshots

Schermafbeelding 2021-05-11 102737

Additional Information

The client is already exists in the DHCP leases
@ameshkov ameshkov added this to the v0.106.3 milestone May 11, 2021
@ameshkov ameshkov added the needs investigation Needs to be reproduced reliably. label May 11, 2021
@ainar-g ainar-g added bug P3: Medium and removed needs investigation Needs to be reproduced reliably. labels May 11, 2021
@ainar-g
Copy link
Contributor

ainar-g commented May 11, 2021

Looks like the feature of turning dynamic leases into static has accidentally been impacted by some recent changes. We'll fix this soon, thanks.

adguard pushed a commit that referenced this issue May 13, 2021
@ainar-g
Pull request: dhcpd: refactor validations
c890f5c 
Updates #3107.
Updates #3127.

Squashed commit of the following:

commit ad64472
Author: Ainar Garipov <[email protected]>
Date:   Thu May 13 14:45:21 2021 +0300

    dhcpd: refactor validations
@ainar-g
Copy link
Contributor

ainar-g commented May 13, 2021

This should be fixed on the edge channel as of revision c890f5c. Could you please check if the problem is gone?

@pascalwinters
Copy link
Author

@ainar-g I just checked it, and it works as expected. Good work!

@ainar-g ainar-g closed this as completed May 13, 2021
adguard pushed a commit that referenced this issue May 19, 2021
@ainar-g
cherry-pick: dhcpd: refactor validations
d747ae3 
Updates #3107.
Updates #3127.

Squashed commit of the following:

commit ad64472
Author: Ainar Garipov <[email protected]>
Date:   Thu May 13 14:45:21 2021 +0300

    dhcpd: refactor validations
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@ainar-g @heyxkhoa
Pull request: dhcpd: refactor validations
7ad790c 
Updates AdguardTeam#3107.
Updates AdguardTeam#3127.

Squashed commit of the following:

commit ad64472
Author: Ainar Garipov <[email protected]>
Date:   Thu May 13 14:45:21 2021 +0300

    dhcpd: refactor validations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ainar-g ainar-g

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.106.3
Development

No branches or pull requests
3 participants
@ainar-g @ameshkov @pascalwinters