Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show local PTR DNS servers and other parameters that were deduced #3136

Closed
ainar-g opened this issue May 12, 2021 · 3 comments
Closed

Show local PTR DNS servers and other parameters that were deduced #3136

ainar-g opened this issue May 12, 2021 · 3 comments
Assignees
@IldarKamalov @EugeneOne1
Labels
enhancement P3: Medium UI
Milestone
v0.107.0

Comments

@ainar-g
Copy link
Contributor

ainar-g commented May 12, 2021

It is often useful both for users and for us to know which values AGH is using when users don't use custom settings. The most obvious example of that is the “Private DNS servers” setting. There should be some kind of way to see the actual value used by AGH in the UI.
@ameshkov ameshkov added this to the v0.107.0 milestone May 14, 2021
@ameshkov
Copy link
Member

There're two pretty simple solutions:

  1. Change placeholder to "Keep this field empty to use the system default DNS server":
    image

  2. Change placeholder to the actual default DNS address (if not set, keep the default DNS resolver there):
    image

@ainar-g please choose the solution you like more.

@ameshkov ameshkov assigned ainar-g and unassigned ameshkov May 14, 2021
@ainar-g
Copy link
Contributor Author

ainar-g commented May 14, 2021

@ameshkov I don't think that putting them into the placeholder is a good idea, since people usually assume that placehoders only contain, well, placeholder text. How about just adding another text?

Screenshot from 2021-05-14 19-13-10

@ameshkov
Copy link
Member

Ah, well, this is a good solution indeed :)

@ainar-g ainar-g assigned EugeneOne1 and unassigned ainar-g May 28, 2021
@adguard adguard closed this as completed in 1e55db4 Jun 1, 2021
heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 3136 show default resolvers
e110420 
Merge in DNS/adguard-home from 3136-show-default to master

Closes AdguardTeam#3136.

Squashed commit of the following:

commit add09a7
Author: Eugene Burkov <[email protected]>
Date:   Tue Jun 1 11:11:24 2021 +0300

    openapi: fix typo

commit 69e402c
Merge: 76e8492 e17e1f2
Author: Eugene Burkov <[email protected]>
Date:   Tue Jun 1 11:09:51 2021 +0300

    Merge branch 'master' into 3136-show-default

commit 76e8492
Author: Ildar Kamalov <[email protected]>
Date:   Tue Jun 1 10:55:09 2021 +0300

    client: check upstreams

commit 05fe6ea
Author: Vlad <[email protected]>
Date:   Mon May 31 19:23:35 2021 +0300

    add defaul resolvers line

commit 8d63c7d
Author: Eugene Burkov <[email protected]>
Date:   Mon May 31 11:56:08 2021 +0300

    all: imp changelog

commit e3912e3
Author: Eugene Burkov <[email protected]>
Date:   Fri May 28 20:23:05 2021 +0300

    all: add local ptr resolvers addresses output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IldarKamalov IldarKamalov

@EugeneOne1 EugeneOne1

Labels
enhancement P3: Medium UI
Projects
None yet
Milestone
v0.107.0
Development

No branches or pull requests
4 participants
@IldarKamalov @ainar-g @ameshkov @EugeneOne1