Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom domain from /etc/hosts resolv failed partly #4079

Closed
bostoneboy opened this issue Jan 4, 2022 · 3 comments
Closed

Custom domain from /etc/hosts resolv failed partly #4079

bostoneboy opened this issue Jan 4, 2022 · 3 comments
Assignees
@EugeneOne1
Labels
bug P3: Medium
Milestone
v0.107.3

Comments

@bostoneboy
Copy link

bostoneboy commented Jan 4, 2022 •
edited
Loading

Issue Details

  • Version of AdGuard Home server:
    • Since v0.107.2
  • How did you install AdGuard Home:
    • GitHub release
  • How did you setup DNS configuration:
    • Router
  • If it's a router or IoT, please write device model:
    • router on vmware ESXI
  • CPU architecture:
    • x86_64
  • Operating system and version:
    • OpenWRT

Expected Behavior

ALL custom domain can resolved from OS's /etc/hosts file.

Actual Behavior

Some custom on /etc/hosts can resolv and some can not since upgrade to v0.107.0 from v0.106.
AFTER try man times, I FOUND that
the new version can only resolv the first line's custom domain when multi line contain the same IP address.

Screenshots

image

Additional Information
@bostoneboy bostoneboy changed the title Custom domain from /etc/hosts resolv fail Custom domain from /etc/hosts resolv failed partly Jan 4, 2022
@ainar-g ainar-g added this to the v0.107.3 milestone Jan 4, 2022
@ainar-g ainar-g self-assigned this Jan 4, 2022
adguard pushed a commit that referenced this issue Jan 12, 2022
@EugeneOne1
Pull request: 4079 fix hosts container aliases
1458600 
Merge in DNS/adguard-home from 4079-hosts-again to master

Updates #4079.

Squashed commit of the following:

commit 6aa8cbf
Merge: 19dba37 34c95f9
Author: Eugene Burkov <[email protected]>
Date:   Wed Jan 12 14:05:30 2022 +0500

    Merge branch 'master' into 4079-hosts-again

commit 19dba37
Author: Eugene Burkov <[email protected]>
Date:   Wed Jan 12 14:05:20 2022 +0500

    aghnet: imp docs

commit 9f341eb
Author: Eugene Burkov <[email protected]>
Date:   Mon Jan 10 18:44:17 2022 +0500

    aghnet: fix races

commit fd66191
Author: Eugene Burkov <[email protected]>
Date:   Thu Jan 6 17:21:14 2022 +0500

    aghnet: fix hosts container aliases
@EugeneOne1 EugeneOne1 assigned EugeneOne1 and unassigned ainar-g Jan 12, 2022
@EugeneOne1
Copy link
Member

@bostoneboy, hello and thanks for the report. Latest build from the edge channel should improve the parsing of /etc/hosts and most likely fix the issue. Could you please install it and check if it actually does?

@EugeneOne1
Copy link
Member

@bostoneboy, I'll close the issue for now. Please feel free to reopen it if the issue reoccurs.

adguard pushed a commit that referenced this issue Jan 21, 2022
@EugeneOne1 @ainar-g
cherry-pick: 4079 fix hosts container aliases
b9682c4 
Merge in DNS/adguard-home from 4079-hosts-again to master

Updates #4079.

Squashed commit of the following:

commit 6aa8cbf
Merge: 19dba37 34c95f9
Author: Eugene Burkov <[email protected]>
Date:   Wed Jan 12 14:05:30 2022 +0500

    Merge branch 'master' into 4079-hosts-again

commit 19dba37
Author: Eugene Burkov <[email protected]>
Date:   Wed Jan 12 14:05:20 2022 +0500

    aghnet: imp docs

commit 9f341eb
Author: Eugene Burkov <[email protected]>
Date:   Mon Jan 10 18:44:17 2022 +0500

    aghnet: fix races

commit fd66191
Author: Eugene Burkov <[email protected]>
Date:   Thu Jan 6 17:21:14 2022 +0500

    aghnet: fix hosts container aliases
@bostoneboy
Copy link
Author

It fixed in v0.107.3, thx

heyxkhoa pushed a commit to heyxkhoa/AdGuardHome that referenced this issue Mar 20, 2023
@EugeneOne1 @heyxkhoa
Pull request: 4079 fix hosts container aliases
62b0db8 
Merge in DNS/adguard-home from 4079-hosts-again to master

Updates AdguardTeam#4079.

Squashed commit of the following:

commit 6aa8cbf
Merge: 19dba37 34c95f9
Author: Eugene Burkov <[email protected]>
Date:   Wed Jan 12 14:05:30 2022 +0500

    Merge branch 'master' into 4079-hosts-again

commit 19dba37
Author: Eugene Burkov <[email protected]>
Date:   Wed Jan 12 14:05:20 2022 +0500

    aghnet: imp docs

commit 9f341eb
Author: Eugene Burkov <[email protected]>
Date:   Mon Jan 10 18:44:17 2022 +0500

    aghnet: fix races

commit fd66191
Author: Eugene Burkov <[email protected]>
Date:   Thu Jan 6 17:21:14 2022 +0500

    aghnet: fix hosts container aliases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EugeneOne1 EugeneOne1

Labels
bug P3: Medium
Projects
None yet
Milestone
v0.107.3
Development

No branches or pull requests
3 participants
@bostoneboy @ainar-g @EugeneOne1