avoid negative variable names

AdguardTeam · Feb 7, 2024 · 6d12f81 · 6d12f81
1 parent 78b3340
commit 6d12f81
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/src/scriptlets/set-attr.js b/src/scriptlets/set-attr.js
@@ -124,13 +124,14 @@ export function setAttr(source, selector, attr, value = '') {
     const allowedValues = ['true', 'false'];
 
     const shouldCopyValue = value.startsWith('[') && value.endsWith(']');
-    const isIllegalValue = value.length !== 0
-        && (nativeIsNaN(parseInt(value, 10))
-            || parseInt(value, 10) < 0
-            || parseInt(value, 10) > 32767)
-        && !allowedValues.includes(value.toLowerCase());
 
-    if (!shouldCopyValue && isIllegalValue) {
+    const isValidValue = value.length === 0
+        || (!nativeIsNaN(parseInt(value, 10))
+            && parseInt(value, 10) > 0
+            && parseInt(value, 10) < 32767)
+        || allowedValues.includes(value.toLowerCase());
+
+    if (!shouldCopyValue && !isValidValue) {
         logMessage(source, 'Illegal attribute value provided');
         return;
     }