Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'googletagservices-gpt' — 'recreateIframeForSlot()' #259

Closed
AdamWr opened this issue Nov 23, 2022 · 0 comments
Closed

Improve 'googletagservices-gpt' — 'recreateIframeForSlot()' #259

AdamWr opened this issue Nov 23, 2022 · 0 comments
Assignees
@stanislav-atr
Labels
enhancement Improvement of existent feature Release: v1.8.2 Resolution: Fixed Status: Closed Version: Scriptlets v1.8

Comments

@AdamWr
Copy link
Member

AdamWr commented Nov 23, 2022 •
edited
Loading

Related to this - AdguardTeam/AdguardFilters#135575
Add this rule:

||securepubads.g.doubleclick.net/tag/js/gpt.js$script,redirect=googletagservices-gpt,important

Website is checking if element .cba iframe exists and if not, it doesn't load content.
If I'm not wrong, if we would add recreateIframeForSlot function, like it's done here - https://searchfox.org/mozilla-central/source/browser/extensions/webcompat/shims/google-publisher-tags.js
then it should fixes this issue.

It looks like that now it's also checking if iframe has data-load-complete (set to true), data-google-container-id and sandbox attribute.
@adguard-bot adguard-bot changed the title Improve googletagservices-gpt Improve googletagservices-gpt — recreateIframeForSlot() Nov 25, 2022
@slavaleleka slavaleleka added the enhancement Improvement of existent feature label Nov 25, 2022
adguard pushed a commit that referenced this issue Dec 15, 2022
@stanislav-atr
AG-17810 improve googletagservices-gpt — recreateIframeForSlot() #259
4a030ea 
Merge in ADGUARD-FILTERS/scriptlets from fix/AG-17810 to release/v1.8

Squashed commit of the following:

commit 7b6380a
Author: Stanislav A <[email protected]>
Date:   Thu Dec 15 13:27:07 2022 +0300

    add ignoreUrls for max-len rule

commit 7fe2698
Author: Stanislav A <[email protected]>
Date:   Wed Dec 14 20:52:19 2022 +0300

    update tests for new defineSlot

commit aaf6202
Author: Stanislav A <[email protected]>
Date:   Wed Dec 14 20:29:29 2022 +0300

    improve slot defining and add testcase

commit 110f170
Author: Stanislav A <[email protected]>
Date:   Wed Dec 14 19:19:02 2022 +0300

    improve googletagservices-gpt — recreateIframeForSlot()
@adguard-bot adguard-bot changed the title Improve googletagservices-gpt — recreateIframeForSlot() Improve 'googletagservices-gpt' — 'recreateIframeForSlot()' Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stanislav-atr stanislav-atr

Labels
enhancement Improvement of existent feature Release: v1.8.2 Resolution: Fixed Status: Closed Version: Scriptlets v1.8
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@AdamWr @adguard-bot @slavaleleka @stanislav-atr