Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'trusted-click-element' - add support for closed ShadowRoot #423

Closed
Alex-302 opened this issue Apr 22, 2024 · 1 comment
Closed

Improve 'trusted-click-element' - add support for closed ShadowRoot #423

Alex-302 opened this issue Apr 22, 2024 · 1 comment
Assignees
@slavaleleka
Labels
enhancement Improvement of existent feature Priority: P4 Release: v1.11.1 Resolution: Fixed Status: Closed Version: Scriptlets v1.11

Comments

@Alex-302
Copy link
Member

Related to AdguardTeam/AdguardFilters#177571

The button is located in the closed Shadow DOM, and the current scriptlet cannot work there.

Alternative solution

Create a separate scriptlet.
@Alex-302
Copy link
Member Author

Added @AdamWr's rule AdguardTeam/AdguardFilters@c301d60

@piquark6046 piquark6046 mentioned this issue May 13, 2024
Closed
3 tasks
@adguard-bot adguard-bot assigned slavaleleka and unassigned maximtop May 27, 2024
adguard pushed a commit that referenced this issue May 29, 2024
@AdamWr
AG-32271 Add ability to click element in closed shadow root in `trust…
2d333ab 
…ed-click-element` scriptlet. #423

Squashed commit of the following:

commit 4b2e958
Author: Adam Wróblewski <[email protected]>
Date:   Mon May 27 14:11:34 2024 +0200

    Add ability to click element in closed shadow root in `trusted-click-element` scriptlet
This was referenced Aug 2, 2024
Closed
Open
Closed
@slavaleleka slavaleleka added the enhancement Improvement of existent feature label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slavaleleka slavaleleka

Labels
enhancement Improvement of existent feature Priority: P4 Release: v1.11.1 Resolution: Fixed Status: Closed Version: Scriptlets v1.11
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Alex-302 @maximtop @adguard-bot @slavaleleka