magnite-streaming #377
Open
magnite-streaming #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jakeseawell
commented
Sep 11, 2024
jakeseawell
commented
- Replaced image: 'destination-realtime-config-auth-filled.png' because of new source field
- Updated streaming markdown doc to reflect changes to and requirements of the new source field
- Replaced image: 'destination-realtime-config-auth-filled.png' because of new source field - Updated streaming markdown doc to reflect changes to and requirements of the new source field
- Replaced destination-realtime-config-auth-filled.png in light-mode with dark-mode version
vfalon
requested changes
Sep 17, 2024
There was a problem hiding this comment.
@jakeseawell thanks for submitting the docs change! Looks good, just one rephrasing comment before we move this forward.
- Changed Note for `source partner` field
Updated “Name of your source partner" to "Your company name"
vfalon
requested changes
Nov 12, 2024
- Added single quotes - Removed line
- Reworded line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.