Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rainfocus Destination Connector Docs #392

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mgmilcher
Copy link
Contributor

Added:

  • new file rainfocus.md that provides the documentation for our destination connector
  • supporting screenshots

@adobe-documentation-team please review.

Copy link
Collaborator

@vgiurgiu vgiurgiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but please address the comments that I left in the draft. Let me know if you have any questions. Thanks!


## Prerequisites {#prerequisites}

* RainFocus API Profile with OAuth (Global)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all these requirements, is there associated documentation on the RainFocus side to link to?


![](/help/destinations/assets/catalog/events-management/rainfocus/rainfocus-destination-mapping.png)

It is also strongly recommended to map additional fields, the following target fields are available from RainFocus
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

first, please use punctuation at the end of the sentence.
next, why is is strongly recommended? something like:

Rainfocus strongly recommends that you map additional fields, as this will [describe reason]. The following target fields are available from RainFocus.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've refactored the wording. Let us know if that works.


## Exported data / Validate data export {#exported-data}

A sample JSON of the exported data is provided below, which uses the example mapping from the screenshot above in the Map attributes and identities section:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, the purpose is rather to show users what to expect on the RainFocus side. Can we instead of this snippet show a screenshot or information about how data looks like once it's available in RainFocus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've added screenshots of how to validate in our platform. Let us know if that works.

@mgmilcher
Copy link
Contributor Author

Thanks for the feedback Victor, we have gone ahead and incorporated your suggested edits. Please review and let us know if there is anything outstanding.

Copy link
Collaborator

@vgiurgiu vgiurgiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation looks good, just one more thing to consider - make sure that the name of the destination matches the name indicated in the documentation. Initially, the name of the destination in the config was "RainFocus Attendee Profiles"
Once the destination config is approved, we can proceed with setting the destination live and publishing the documentation. Thank you very much for your efforts. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants