stop requiring mingw labels on Openj9 JDK8+11 builds #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stewart X Addison <[email protected]>
|
Thank you for creating a pull request! |
|
run tests |
|
mingw is not required. OpenJ9 used to use mingw but switched to use clang ~Nov 2018. |
🟢 PR TESTER RESULT 🟢✅ All pipelines passed! ✅ |
M-Davies
approved these changes
Mar 4, 2021
Seems to have just been an oversight that this limitation wasn't removed at that time :-) Thanks for the confirmation. |
|
Since this passed the checks it should be fairly safe. I'll merge and kick off 8 and 11 pipelines and provide the links here - we can see where all the jobs end up :-) |
|
vsebe
pushed a commit
to vsebe/ci-jenkins-pipelines
that referenced
this pull request
Jul 11, 2022
Fix sign_build after merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on adoptium/temurin-build#700 and the checks in #66 (comment) I think the tags are historic and no longer necessary as all bulid machines are set up the same way and the OpenJ9 builds no longer require special treatment (In fact 15+ do not have this tag).
@pshipton I presume you are not aware of any reason to keep
mingwlabels on the OpenJ9 builds to tie it to the IBM Cloud (SoftLayer) build machines we have?Signed-off-by: Stewart X Addison [email protected]