Ensure all builds can run on multiple machines

[sxa]

This may be a duplicate, but we have some jobs that are currently locked onto specific build machines. For redundancy reasons this is a bad idea. Reasons are likely historic and hopefully not valid any more but we need to validate this and modify the tags:

EDIT 22/4/2020: The list below is now far smaller so of the original list we only have Corretto JDK8 explicitly locked to a hostname now (although others are locked for other tagging reasons - see comments)

./pipelines/jobs/configurations/jdk9_pipeline_config.groovy:                additionalNodeLabels: 'build-macstadium-macos1010-1',
./pipelines/jobs/configurations/jdk8_pipeline_config.groovy:                        corretto: 'build-macstadium-macos1010-1',
./pipelines/jobs/configurations/jdk10_pipeline_config.groovy:                additionalNodeLabels: 'build-macstadium-macos1010-1',

Original list for historic reference:

[sxa@sxat470p pipelines]$ find . -type f -print | xargs grep build- | grep groovy:
./build/openjdk11_pipeline.groovy:                        hotspot: 'build-macstadium-macos1010-1',
./build/openjdk11_pipeline.groovy:                        openj9:  'build-macstadium-macos1010-2'
./build/openjdk11_pipeline.groovy:                additionalNodeLabels : 'build-macstadium-macos1010-2',
./build/prTester/pr_test_pipeline.groovy:                    BUILD_FOLDER        : "build-scripts-pr-tester/build-test",
./build/openjdk8_pipeline.groovy:                        hotspot : 'build-macstadium-macos1010-1',
./build/openjdk8_pipeline.groovy:                        corretto: 'build-macstadium-macos1010-1',
./build/openjdk8_pipeline.groovy:                        openj9  : 'build-macstadium-macos1010-2'
./build/openjdk8_pipeline.groovy:                additionalNodeLabels : 'build-macstadium-macos1010-2',
./build/openjdk8_pipeline.groovy:                        openj9  : 'build-joyent-centos69-x64-1'
./build/openjdk_pipeline.groovy:                additionalNodeLabels: 'build-macstadium-macos1010-1',
./build/common/openjdk_build_pipeline.groovy: *  1. Check out and build JDK by calling build-farm/make-adopt-build-farm.sh
./build/common/openjdk_build_pipeline.groovy:                    def signJob = context.build job: "build-scripts/release/sign_build",
./build/common/openjdk_build_pipeline.groovy:                            projectName: "build-scripts/release/sign_build",
./build/common/openjdk_build_pipeline.groovy:        def installerJob = context.build job: "build-scripts/release/create_installer_mac",
./build/common/openjdk_build_pipeline.groovy:                projectName: "build-scripts/release/create_installer_mac",
./build/common/openjdk_build_pipeline.groovy:        def installerJob = context.build job: "build-scripts/release/create_installer_windows",
./build/common/openjdk_build_pipeline.groovy:                projectName: "build-scripts/release/create_installer_windows",
./build/common/openjdk_build_pipeline.groovy:                                    context.sh(script: "./build-farm/make-adopt-build-farm.sh")
./build/common/build_base_file.groovy:                context.build job: 'build-scripts/release/refactor_openjdk_release_tool',
./build/openjdk9_pipeline.groovy:                additionalNodeLabels: 'build-macstadium-macos1010-1',
./build/openjdk10_pipeline.groovy:                additionalNodeLabels: 'build-macstadium-macos1010-1',
[sxa@sxat470p pipelines]$ 

jdk8u-windows-x64-openj9 is also locked to build-softlayer-win2012r2-x64-1 for some reason at present - likely because we've historically had custom setups on the windows boxes due to the lack of a standard playbook and have installed some custom compilers and appropriate tags on certain machines

[lumpfish]

Also, https://ci.adoptopenjdk.net/job/build-scripts/job/release/job/create_installer_windows/ appears to be tied to a machine (maybe wix needs to be on more machines?):

(pending—Waiting for next available executor on ‘build-softlayer-win2012r2-x64-1’) 

[sxa]

Docker build jobs also appear machine-specific

[sxa]

• aarch64 build machine
• AIX xlc16 machine

[sxa]

macos builds (Checked JDK11/J9) are tied to macos10.14&&build&&mac&&x64 which is only served by build-macstaduim-macos1014-1

[sxa]

JDK8/J9/Win32 is locked to build-softlayer-win2012r2-x64-1

[sxa]

All AIX/J9 builds currently locked to https://ci.adoptopenjdk.net/computer/test-ibm-aix71-ppc64-1 (Requires AIX 7.1.5)

[sxa]

JMC builds seem tied to the build-scalway-ubuntu system as demonstrated by adoptium/infrastructure#1336

[sxa]

OpenJ9 JDK8 builds now released as they can run on either of the new windows ibmcloud systems

[sxa]

NOTES:

• git-hg jobs are now [locked onto one machine] as a result of server decomissioning
• Dragonwell currently locked to alibaba machines
• macos signing can get delayed due it it sharing resource with test systems

[M-Davies]

@sxa Can this be moved to https://github.com/AdoptOpenJDK/ci-jenkins-pipelines?

[sxa]

@sxa Can this be moved to https://github.com/AdoptOpenJDK/ci-jenkins-pipelines?

Debatable - it's not purely a fix to the tags in there, it's also about making sure appropariate systems are available. I don't care too much where it is though.

[sxa]

Related: adoptium/infrastructure#1948
At the moment, only Azure systems are tagged for WiX (installer) jobs.

[sxa]

Note: The OpenJ9 builds (At least JDK8) are restricted to these two machines (not labelled to run on azure unlike others)

[sxa]

Alibaba aarch64 builds are currently locked onto one machine (they have to run on alibaba hardware for now - we'll almost certainly have to allow both machines to be options for building. Today it got locked out because the docker_build_multiarch job got scheduled on there.

[sxa]

SUMMARY

Many of these have now been resolved. From the top:

• macos machine-specific entries in the pipelines have now been removed (Corretto excepted) and run on macos10.14 (2 machines)
• JDK8/J9 now runs on docker hosts so is not tied to the (now decomissioned) joyent build machine
• create_installer_windows can now run on two azure machines but is being widened further under Allow build-ibmcloud-win2012r2-x64-1 to run installer (WiX) jobs infrastructure#1950
• aarch64 build machines are now docker containers, so no longer tied to one aarch64 build host
• There are now two machines tagged as OpenJ9 XLC16 build systems
• JDK8/J9/Win32 is now able to run on four different machines - win2012&&build&&windows&&x86-32
• Dragonwell Linux/aarch64 tied to alibaba machines due to architecture requirements, but there are two available. Other platforms can now run anywhere
• WiX Windows installer jobs have been partially released (Can run on azure build machines) but Allow build-ibmcloud-win2012r2-x64-1 to run installer (WiX) jobs infrastructure#1950 will free it up properly
• OpenJ9 machines no longer depend on mingw-cygwin

Remaining:

• Linux installers tied to [ubuntu&&fpm](https://ci.adoptopenjdk.net/label/ubuntu&&fpm] which is only matching build-scaleway-ubuntu1604-x64-1
• git-hg tied to infra-aws-ubuntu1804-x64-1 which really needs to be decomissioned as per Decomission: Reduce number of AWS machines that we use infrastructure#1843
• Possibly some of the parts of docker_build_multiarch
• (Memo to self: Verify that JMC will run with the digitalocean machine offline. Evidence suggests not - it ends up on an azure agent and fails. 7.x.x had previously been failing on them)