fix fabric8io#3957: Lister onOpen should be called before marking t…

…he connection as open
AdrianFarmadin · Mar 10, 2022 · 2e17ef5 · 2e17ef5
1 parent 43bd021
commit 2e17ef5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## CHANGELOG
 
+### 5.12.2
+* Fix #3957: Lister `onOpen` should be called before marking the connection as open
+
 ### 5.12.1 (2022-02-04)
 
 #### Bugs

diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/okhttp/OkHttpWebSocketImpl.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/okhttp/OkHttpWebSocketImpl.java
@@ -82,8 +82,8 @@ public void onOpen(okhttp3.WebSocket webSocket, Response response) {
             response.close();
           }
           OkHttpWebSocketImpl value = new OkHttpWebSocketImpl(webSocket);
-          future.complete(value);
           listener.onOpen(value);
+          future.complete(value);
         }
 
         @Override