-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding Kaios app and removing need to update chunks in build/index.html #35
base: master
Are you sure you want to change the base?
Conversation
Can you elaborate a bit more on what this does? |
@AdrianMachado - Looks like the main purpose is this part: INLINE_RUNTIME_CHUNK=false in the build command. The reason you need this is because for Privileged apps, inline scripts are not allowed and the default is to inject the minified chunks inline. I've fixed this a different way using the env-cmd library and making the build environment variables have INLINE_RUNTIME_CHUNK=false inside itself. I'd recommend we do it that way vs. react scripts rewired and all of this other jazz. I've never had much luck using that package. More trouble than it's worth. |
yes, main reason is to remove inline script. also, removed cursor and add manifest.webapp |
@patburke234 so we shouldn't merge this in then if you already resolved it? |
No description provided.