Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding Kaios app and removing need to update chunks in build/index.html #35

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

shishirarora3
Copy link

No description provided.

@AdrianMachado
Copy link
Owner

Can you elaborate a bit more on what this does?

@AdrianMachado AdrianMachado self-requested a review June 15, 2020 03:12
@patburke234
Copy link
Collaborator

@AdrianMachado - Looks like the main purpose is this part: INLINE_RUNTIME_CHUNK=false in the build command. The reason you need this is because for Privileged apps, inline scripts are not allowed and the default is to inject the minified chunks inline.

I've fixed this a different way using the env-cmd library and making the build environment variables have INLINE_RUNTIME_CHUNK=false inside itself.

I'd recommend we do it that way vs. react scripts rewired and all of this other jazz. I've never had much luck using that package. More trouble than it's worth.

@shishirarora3
Copy link
Author

yes, main reason is to remove inline script. also, removed cursor and add manifest.webapp

@AdrianMachado
Copy link
Owner

@patburke234 so we shouldn't merge this in then if you already resolved it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants