Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add documentation for component methods #1208

Merged
merged 1 commit into from
Oct 4, 2021

Conversation

renrizzolo
Copy link
Contributor

Add Methods section to docs

Description

Methods are available in the props.json file but they're not being documented.

Was a little complicated having a single table for all methods like the PropTypes table, because of having to do multiple rows for params within the method row. So I've separated them into blocks with a params table.

The screen shot aims to show the full documentation capability using JSDoc.

e.g

/**
* stateToHTML method description
* @param {string} input - the input string
* @param {boolean} anotherParam - a boolean flag
* @returns {object} the return type contains all the stuff you need
**/

Does this PR introduce a breaking change?

  • Yes
  • No

Manual testing step?

Screenshots (if appropriate):

Screen Shot 2021-10-01 at 4 28 58 pm

@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #1208 (3b59438) into master (1efa941) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1208   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           93        93           
  Lines         1381      1381           
  Branches       343       343           
=========================================
  Hits          1381      1381           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1efa941...3b59438. Read the comment docs.

Copy link
Contributor

@pphminions pphminions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍏

@pphminions
Copy link
Contributor

merging 🚀

@pphminions pphminions merged commit 17bed00 into master Oct 4, 2021
@pphminions pphminions deleted the docs-add-methods-table branch October 4, 2021 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants