Fix MS-SSIM implementation and add phase-plots #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of plotting wave phase and amplitude side by side, we can show them together on the sample plot using glyphs that do not have rotation symmetry. The phase is shown using the rotation of the glyph and the magnitude is the color of the glyph.
Instead of using a sequential perceptually uniform color scheme we should use a cyclic color scheme for the phase becase 2PI is the same a 0. This approach is not perceptually uniform, but coloring the phase and using the brightness for magnitude makes the phase more salient.
The SSIM implementation makes an approximation which remove the structure component. However, this assumption may not be valid when alpha beta gamma are not equal to 1.
The Luminance is supposed to be applied from the largest scale not the smallest scale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was re-reading the MS-SSIM paper, and I update the implementation to match it. I have also added a plotting function which uses glyphs to represent the phase angle of a complex image.