Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Autofit a Siemens star to image for MTF calculation #80

Merged
merged 11 commits into from
Jul 13, 2022
Merged

API: Autofit a Siemens star to image for MTF calculation #80

merged 11 commits into from
Jul 13, 2022

Commits on Jul 13, 2022

  1. API: Refactor SiemensStar to only count materials as blades 

    The n_sectors param was a little wierd because odd numbers of
blades would not be evenly spaced. This is because dark spaces
between blades were counted as blades. This fixes that and adds
a two functions to compute the spatial frequency at a given
radius or find a radius that computes a frequency.
    @carterbox
    carterbox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    ea4c768 View commit details
    Browse the repository at this point in the history

  2. DOC: Fix "Siemens star" spelling

    @carterbox
    carterbox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    af38b46 View commit details
    Browse the repository at this point in the history

  3. API: Compute mpf_lwkj with image and no Phantom 

    Updating the mtf_lwkj method such that it is computed without requiring
a Phantom object as a template. This allows this function to be used on
real data with less work. There are new keywords for this function
because information needs to be supplied that was taken from the
Phantom. The frequency space is now sampled linearly.

The demo notebook has been updated with the new API.
    @carterbox
    carterbox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    207fe7f View commit details
    Browse the repository at this point in the history

  4. API: Remove deprecated compute_mtf function

    @carterbox
    carterbox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    32dacfb View commit details
    Browse the repository at this point in the history

  5. REF: Automatic number of samples for get_line_at_radius 

    Because:
- The number of samples could be set too low

Sampling the line at a radius with less points than PI * diameter
of the circle is insufficient to capture high frequency information
that we are tying to characterize. The number of angles is now
automatically at least PI * diameter. Technically, the smaller radii
are over sampled, but that should be fine.
    @carterbox
    carterbox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    e0647ea View commit details
    Browse the repository at this point in the history

  6. REF: Compress function fitting for MTF calculation 

    Because:
  - brief code is better
  - more documentation is better

The size of the code for this MTF calcuation based on fitting a
periodic function was simplified and compresed. Documentation was
added. It should be easier to understand.
    @carterbox
    carterbox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    afb5f23 View commit details
    Browse the repository at this point in the history

  7. API: Use square function for MTF calc instead of sine 

    Because:
  - The Siemens Star that we are fitting is a square function
  - This prevents MTF values larger than 1

Swapped out the sin + cos function for computing the MTF by fitting a
function to the image of the Siemens star. Replaced it with a square
function from scipy.signal because this is the actual expected signal
from the image. The sine functions would cause MTF values higher than
unity because they have to be curved.
    @carterbox
    carterbox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    2542494 View commit details
    Browse the repository at this point in the history

  8. STY: PEP8 Adjustments to white space docs

    @carterbox
    carterbox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    79394e2 View commit details
    Browse the repository at this point in the history

  9. BUG: Fix scipy imports in xd.metrics.standards

    @carterbox
    carterbox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    4df64c4 View commit details
    Browse the repository at this point in the history

  10. BUG: Add self to SiemensStar class methods

    @carterbox
    carterbox committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    807e961 View commit details
    Browse the repository at this point in the history

  11. Use correct version in versionchanged

    @carterbox
    carterbox authored Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a1e2e2c View commit details
    Browse the repository at this point in the history