-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves Apple pay errors #69
base: develop
Are you sure you want to change the base?
Improves Apple pay errors #69
Conversation
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Hello @dimitriBouteille, Thank you for your contribution. We will review this PR and merge it afterwards. Best Regards, |
Hi @RokPopov & @candemiralp Can you look this MR in order to maybe include it in the next release. Thanks ! |
agreement_ids: window.checkout.agreementIds | ||
}; | ||
} | ||
postData.paymentMethod = agreementsAssigner(postData.paymentMethod); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @dimitriBouteille,
Thank you for your contribution. I see that you've implemented the usage of agreementsAssigner()
. However, I couldn't find the relevant import in RequireJS import block.
Is Magento_CheckoutAgreements/js/model/agreements-assigner
required to be imported to the class?
Best regards,
Can
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @candemiralp
I think this line can be remove :)
Summary
This MR improves error display with Apple Pay checkout. The user can easily change the error handling thanks to the new functions.
onShippingContactSelect
The
addressUnserviceable
error is displayed by ApplePay if not shipping method.startPlaceOrder
The explicit placeOrder error or
Your payment failed, Please try again later
is displayed in the cart if an error occurs during the placeOrder.Resolve #59