Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves Apple pay errors #69

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

dimitriBouteille
Copy link
Contributor

@dimitriBouteille dimitriBouteille commented Dec 13, 2023

Summary

This MR improves error display with Apple Pay checkout. The user can easily change the error handling thanks to the new functions.

onShippingContactSelect

The addressUnserviceable error is displayed by ApplePay if not shipping method.

The code that indicates that the merchant can’t provide service to the shipping address (for example, can’t deliver to a P.O. Box).

281679485-bbcd4548-8dad-406e-86d3-d05c10896de7

startPlaceOrder

The explicit placeOrder error orYour payment failed, Please try again later is displayed in the cart if an error occurs during the placeOrder.

IMG_20231213_172507 (1)


Resolve #59

@dimitriBouteille dimitriBouteille requested a review from a team as a code owner December 13, 2023 17:02
Copy link

sonarcloud bot commented Dec 14, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@candemiralp
Copy link
Member

Hello @dimitriBouteille,

Thank you for your contribution. We will review this PR and merge it afterwards.

Best Regards,
Can

@dimitriBouteille
Copy link
Contributor Author

Hi @RokPopov & @candemiralp

Can you look this MR in order to maybe include it in the next release.

Thanks !

agreement_ids: window.checkout.agreementIds
};
}
postData.paymentMethod = agreementsAssigner(postData.paymentMethod);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dimitriBouteille,

Thank you for your contribution. I see that you've implemented the usage of agreementsAssigner(). However, I couldn't find the relevant import in RequireJS import block.

Is Magento_CheckoutAgreements/js/model/agreements-assigner required to be imported to the class?

Best regards,
Can

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @candemiralp

I think this line can be remove :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple Pay - error message never displayed
2 participants