Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ECP-8907] - Fix Google Pay redirect to success page after payment #77

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

raoulritter
Copy link
Member

@raoulritter raoulritter commented Jan 24, 2024

Summary

After the changes on V9 of main payment module, it was seen that Google Pay express couldn't redirect shopper to success page. The issue was main module couldn't fetch the quoteId from quote object on product detail page. Because, quote object is not available at that moment.

This PR applies the fix 2462 to express module repository.

Tested scenarios

  • Tested Googlepay payment on product, cart and minicart view.

@raoulritter raoulritter requested a review from a team as a code owner January 24, 2024 15:55
Copy link

sonarcloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@candemiralp candemiralp changed the title [ECP-8907] - Fix quoteId on productView [ECP-8907] - Fix Google Pay redirect to success page after payment Jan 25, 2024
@candemiralp candemiralp added the Fix Indicates a bug fix label Jan 25, 2024
@candemiralp candemiralp merged commit 79b6e24 into develop Jan 25, 2024
7 checks passed
@candemiralp candemiralp deleted the ECP-8907 branch January 25, 2024 07:59
@khushboo-singhvi khushboo-singhvi mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Indicates a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants