PW-1188: Add applicationInfo into terminal API requests #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleffio
requested review from
AlexandrosMor,
cyattilakiss,
msilvagarcia and
rikterbeek
as code owners
Aleffio
changed the title
Co-Authored-By: Marcos Garcia <[email protected]>
rikterbeek
reviewed
Dec 23, 2019
| */ | ||
| public function getMerchantApplication() | ||
| { | ||
| return isset($this->data['merchantApplication']) ? $this->data['merchantApplication'] : null; |
There was a problem hiding this comment.
let's slowly migrate off of the data field and use proper string value for this. protected $merchantApplication;
There was a problem hiding this comment.
ignore it as this will mean for every param we added it will be a major release for our merchants what is not ideal
There was a problem hiding this comment.
we can deprecate the interface so we are more flexible in the future.
| @@ -22,6 +36,6 @@ public function __construct($service, $asynchronous) | |||
| } else { | |||
| $this->endpoint = $service->getClient()->getConfig()->get('endpointTerminalCloud') . '/sync'; | |||
| } | |||
| parent::__construct($service, $this->endpoint); | |||
| parent::__construct($service, $this->endpoint, $allowApplicationInfo = false, $this->allowApplicationInfoPOS); | |||
There was a problem hiding this comment.
$allowApplicationInfo = false change this to $allowApplicationInfo.
There was a problem hiding this comment.
Suggested change
| parent::__construct($service, $this->endpoint, $allowApplicationInfo = false, $this->allowApplicationInfoPOS); | |
| parent::__construct($service, $this->endpoint, $this->allowApplicationInfo, $this->allowApplicationInfoPOS); |
… interface as deprecated so we can remove it in future releases to cleanup the config object.
msilvagarcia
approved these changes
Dec 23, 2019
AlexandrosMor
approved these changes
Dec 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add applicationInfo for terminal API requests inside SaleToAcquirerData.
If SaleToAcquirerData is empty, just add ApplicationInfo and base64encode it.
If SaleToAcquirerData contains data, add ApplicationInfo to it.
Tested scenarios
Fixed issue: