Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix config typehint #189

Closed
wants to merge 2 commits into from
Closed

fix config typehint #189

wants to merge 2 commits into from

Conversation

mr-feek
Copy link

@mr-feek mr-feek commented Apr 20, 2020

Description
This param should be a union type of client or null

msilvagarcia
msilvagarcia previously approved these changes Apr 20, 2020
View reviewed changes
@cyattilakiss
Copy link
Contributor

Hi @mr-feek ,

Thanks for creating the PR we really appreciate your contribution :)
We are going to look into it, review it and merge it soon.

Best,
Attila
Adyen

@mr-feek
Copy link
Author

mr-feek commented Apr 20, 2020

I'd totally recommend you guys pull in https://github.com/vimeo/psalm to find more errors like this :)

@cyattilakiss
Copy link
Contributor

Hi @mr-feek ,

Thank you for the PR and the recommendation. We are going to look into the recommended tool.
I see that another contributor has just fixed the same issue as your PR, so I will close this one for now, but we still do appreciate the change request :)

Best,
Attila
Adyen

@acampos1916 acampos1916 mentioned this pull request May 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyattilakiss cyattilakiss cyattilakiss approved these changes

@AlexandrosMor AlexandrosMor AlexandrosMor approved these changes

@rikterbeek rikterbeek rikterbeek approved these changes

@Aleffio Aleffio Aleffio approved these changes

@msilvagarcia msilvagarcia msilvagarcia left review comments

@acampos1916 acampos1916 Awaiting requested review from acampos1916

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mr-feek @cyattilakiss @msilvagarcia @Aleffio @rikterbeek @AlexandrosMor