Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 13.0.0 #367

Merged
merged 6 commits into from
Jun 8, 2022
Merged

Release 13.0.0 #367

merged 6 commits into from
Jun 8, 2022

Conversation

AlexandrosMor and others added 3 commits May 12, 2022 16:21
* Add test and get list for webhooks

Add test and get list endpoints for webhook merchants account

* Add constants sonarcloud suggestions

* Fix phpbcs error
…ent api (#363)

* Add Get /PaymentMethodSettings

* Add paymentMethodSettings in MerhcantAccount

* Update src/Adyen/Service/Management.php

Remove unused using

* Remove empty line

* Remove unused line
* [PW-6693] - Checkout API version changed

* [PW-6693] - Debug failing unit tests

* [PW-6693] - Debug failing unit tests

* [PW-6693] - Update donationAccount for donations test

* [PW-6693] - Revert GA debug commits

* [PW-6693] - Passing null parameter instead of string deprecated for json_decode() function

* [PW-6693] - Version bump to 13.0.0 and update README.md

* [PW-6693] - Code formatting
@sonarcloud
Copy link

sonarcloud bot commented Jun 3, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

AlexandrosMor
AlexandrosMor previously approved these changes Jun 3, 2022
wboereboom
wboereboom previously approved these changes Jun 3, 2022
Copy link
Contributor

@wboereboom wboereboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but with the disclaimer that it is hard for me to judge the PHP code

peterojo
peterojo previously approved these changes Jun 3, 2022
@RokPopov RokPopov dismissed stale reviews from peterojo, wboereboom, and AlexandrosMor via 1fdc753 June 8, 2022 13:31
* [PW-6776] - Add donationAccount to test configuration file

* [PW-6776] - Add donationAccount parameter to environmental variables for GA

* [PW-6776] - Add INTEGRATION_DONATION_ACCOUNT variable to workflow

* [PW-6776] - Code formatting (Sonar Cloud)

* [PW-6776] - Code formatting

* [PW-6776] - Code formatting

* [PW-6776] - Remove redundant variable declaration

* [PW-6776] - Revert commit #545953a

* [PW-6776] - Code formatting
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@candemiralp candemiralp merged commit f3ba999 into main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants