PW-458: Added timeout optional configuration #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rikterbeek
reviewed
Jul 4, 2018
| // 'SaleToPOIRequest.PaymentRequest.PaymentTransaction.AmountsReq.Currency', | ||
| // 'SaleToPOIRequest.PaymentRequest.PaymentTransaction.AmountsReq.RequestedAmount', | ||
| // //PaymentData is optional, if not provided it will perform an authorisation(no refunds) | ||
| // 'SaleToPOIRequest.PaymentRequest.PaymentData.PaymentType', | ||
| ); |
There was a problem hiding this comment.
Can we just remove the complete requiredFields ?
There was a problem hiding this comment.
removing all the required fields in a separate PR
|
yes
2018-07-04 14:47 GMT+08:00 Rik ter Beek <[email protected]>:
… ***@***.**** commented on this pull request.
------------------------------
In src/Adyen/Service/ResourceModel/Payment/TerminalCloudAPI.php
<#68 (comment)>
:
> @@ -7,13 +7,13 @@ class TerminalCloudAPI extends \Adyen\Service\AbstractResource
protected $_requiredFields = array(
'SaleToPOIRequest.MessageHeader.POIID',
- 'SaleToPOIRequest.MessageHeader.ServiceID',
- //TODO fix: actually works with only first two levels
- 'SaleToPOIRequest.PaymentRequest.SaleData.SaleTransactionID.TransactionID', //reference
- 'SaleToPOIRequest.PaymentRequest.PaymentTransaction.AmountsReq.Currency',
- 'SaleToPOIRequest.PaymentRequest.PaymentTransaction.AmountsReq.RequestedAmount',
- //PaymentData is optional, if not provided it will perform an authorisation(no refunds)
- 'SaleToPOIRequest.PaymentRequest.PaymentData.PaymentType',
+ 'SaleToPOIRequest.MessageHeader.ServiceID'
+ // /sync can be a status call, in that case we don't send PaymentRequest
+// 'SaleToPOIRequest.PaymentRequest.SaleData.SaleTransactionID.TransactionID', //reference
+// 'SaleToPOIRequest.PaymentRequest.PaymentTransaction.AmountsReq.Currency',
+// 'SaleToPOIRequest.PaymentRequest.PaymentTransaction.AmountsReq.RequestedAmount',
+// //PaymentData is optional, if not provided it will perform an authorisation(no refunds)
+// 'SaleToPOIRequest.PaymentRequest.PaymentData.PaymentType',
);
Can we just remove the complete requiredFields ?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#68 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Am3gargm8EAbhLgdpaAl1J8wAbOGioh6ks5uDGT_gaJpZM4U-0A8>
.
|
rikterbeek
approved these changes
Jul 4, 2018
lancergr
approved these changes
Jul 4, 2018
Aleffio
added a commit
that referenced
this pull request
Jul 6, 2018
* Add x-api key for Terminal API (Cloud) * Added POIID entr for Unique Terminal ID * First iteration for Terminal API (Cloud) * PW-351: Moved buildPosPaymentRequest to Util. Refactoring. * PW-351: Exclude POS tests. * PW-351: Tests change to EUR * PW-351: Provide original amount * PW-351: Changed isset to !empty. * PW-351: Refactoring. * PW-351: Fix Headers. * PW-351: Minor fixes * PW-351: Fixed POS tests if apikey or poiid not provided. * Add adjustAuthorisation to modification models * Fix php5.3 compatibility in tests * Fix typo * Update LICENSE * PW-421: minor fixes for terminalCloudApi after review * PW-421: removed print statement * PW-421: Adding Checkout and Checkout Utility support * PW-421: Adding Checkout and Checkout Utility support, modified CurlClient to make it testable * PW-241: fixed failing test * PW-421: removed comment * PW-421: include Checkout unit tests, simplified CheckoutUtility endpoint * PW-421: Added ApiKeyAuthenticatedService and renamed supportsXAPIKey to requiresApiKey * PW-421: removed phpstorm comment * PW-421: fix for Travis * PW-421: fix for PHP <= 5.4 * PW-421: Readded previous tests, changed Checkout API key message if not provided, added fail() call to the failureTests * PW-421: Removed redundant line in xml * PW-421: Simplified ApiKeyAuthenticatedService structure * PW-448 Added mocking to Authorise API (#65) * PW-448: Added mocking for Authorise API, refactored CheckoutMockClient * PW-448: added curlError function for easier mocking * PW-448: Added test on happy flow to prevent full card data to be logged * PW-448: Replaced assertEquals with assertInstanceOf for exceptions * PW-448: Treat logger as stub * PW-448: Added check for cse encrypted data * Version bump 1.5.0 * Removed getPOIID from config/interface * Updated setup/verify endpoints with paymentSession/paymentsResult (#67) * Updated setup/verify endpoints with paymentSession/paymentsResult * added missing requiredfields * PW-458: Added timeout optional configuration (#68) * PW-458: Added timeout optional configuration * reverted _requiredfields * PW-445: Removed required fields, validate function and related tests (#69) * PW-445: Removed required fields, validate function and related tests * Removed MissingFields test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added timeout optional configuration, to be used on Magento2 terminal API.
Removed required fields relative to the payment, since we use the same endpoint for Status call as well.