Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all marketpay APIs #92

Merged
merged 2 commits into from
Nov 30, 2018
Merged

Add all marketpay APIs #92

merged 2 commits into from
Nov 30, 2018

Conversation

rikterbeek
Copy link
Contributor

Description

Tested scenarios

Fixed issue:

tests/MockTest/NotificationTest.php Outdated Show resolved Hide resolved
src/Adyen/Client.php Outdated Show resolved Hide resolved
src/Adyen/Client.php Outdated Show resolved Hide resolved
src/Adyen/Client.php Outdated Show resolved Hide resolved
src/Adyen/Client.php Outdated Show resolved Hide resolved
Copy link
Contributor

@cyattilakiss cyattilakiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen that most of the functions and properties had a leading underscore which should be removed but to be honest it occurs too much that I don't know if it worth it :)

@rikterbeek
Copy link
Contributor Author

@cyattilakiss let's do a seperate PR to fix it across all fields.

@rikterbeek rikterbeek merged commit d22384b into develop Nov 30, 2018
@cyattilakiss cyattilakiss deleted the feature/marketpay-apis branch January 9, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants