[PW-6905] Fix for vulnerability to timing attack in hmac comparison #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jillingk
requested review from
AlexandrosMor,
rikterbeek,
acampos1916,
candemiralp and
michaelpaul
as code owners
michaelpaul
approved these changes
Jul 13, 2022
acampos1916
approved these changes
Jul 13, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of using the == comparison, we should use the
hmac.compare_digest(merchant_sign_str, expected_sign)to compare the hmac signings.Tested scenarios
Ran the unit tests.
Fixed issue:
#168