[PW-2570] Complete refunds based on original PSP reference instead of the notification PSP reference

[floorjubbega]

Describe the bug

There can be cases when the refund fails. Example iDeal transaction:

1. You start the payment, an offer is created
2. You go back and open the app again, a new second offer is created
3. As soon as you finish the payment the first offer is cancelled and an offer_closed notification is sent with a PSP reference.
4. For the payment you get an Authorisation notification with another PSP reference. In some cases the offer_closed notification is going to be the "last" notification for the order and then the PSP reference will not match, therefore the refund cannot be done.

It would be preferable to store the original PSP reference for the order when the async notification from our server or the sync authorisation response from the API is processed. It appears the PSP reference is stored in the s_plugin_adyen_order_payment_info table, which can be used to fetch these details instead of the notification.

To Reproduce

Double check if s_plugin_adyen_order_payment_info db table is the best place to store the original PSP reference.

• In case of sync authorisation response store the psp reference in the s_plugin_adyen_order_payment_info db table
• In case of async authorisation notification if there is no PSP reference already stored in the s_plugin_adyen_order_payment_info db table, then store the original PSP reference. If it does not exist store the PSP reference field in the same db table.

Changes
Change the refund function

adyen-shopware5/Components/Adyen/RefundService.php

Line 60 in 61bf786

$notification = $this->notificationManager->getLastNotificationForOrderId($orderId);

to use the s_plugin_adyen_order_payment_info db table's psp reference instead of the notifications psp reference.

If the last notification has a different PSP reference than the original PSP reference the refund can still be done because it is using the s_plugin_adyen_order_payment_info table's psp reference.