Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ap 257 notifcations reponse #115

Merged
merged 2 commits into from
Jan 19, 2021

Conversation

bortefi
Copy link
Contributor

@bortefi bortefi commented Jan 15, 2021

Summary

Responses on incoming notification:

  • process Authentication, on failure return failed message (HTTP 401)
  • process HmacKey, on failure return failed message (HTTP 401)
  • all other notifications sent response '[accepted]' (HTTP 202)
  • use unified way to create JsonResponse with status code (aligned responses with docs and SW 6 Plugin)
  • refactor Validation to chained validation

Processing notification:

  • skip report notification

Tested scenarios

Test cases:

  • Missing Authentication exception handling
  • Invalid Authentication exception handling
  • Missing Hmac key exception handling
  • Invalid Hmac key exception handling
  • Skip Report notification

Fixed issue: #111

@bortefi
Copy link
Contributor Author

bortefi commented Jan 15, 2021

@acampos1916

To be verified with pull request: #114

Components/IncomingNotificationManager.php

  • PR 115 has the save method a check to skip empty and Report Notifications
  • PR 114 has an altered method "save" -> "convert"

To have both PR's working the skip report notification check should be moved to the "saveTextNotification" method.

@peterojo peterojo self-requested a review January 19, 2021 09:31
@cyattilakiss cyattilakiss merged commit 5fdb3fd into Adyen:develop Jan 19, 2021
@acampos1916
Copy link
Member

@acampos1916

To be verified with pull request: #114

Components/IncomingNotificationManager.php

  • PR 115 has the save method a check to skip empty and Report Notifications
  • PR 114 has an altered method "save" -> "convert"

To have both PR's working the skip report notification check should be moved to the "saveTextNotification" method.

Thanks for this heads up @bortefi. We've decided to merge #115 before #114 and address the conflicts there.

@bortefi bortefi deleted the AP-257-notifcations-reponse branch January 19, 2021 12:44
@acampos1916 acampos1916 mentioned this pull request Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants