Ap 256 payment data missing #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bortefi
requested review from
acampos1916,
cyattilakiss and
msilvagarcia
as code owners
bortefi
commented
Jan 18, 2021
| @@ -144,7 +144,7 @@ private function paymentDetails(string $post, string $detail) | |||
| $this->Front()->Plugins()->ViewRenderer()->setNoRender(); | |||
|
|
|||
| $postData = $this->Request()->getPost(); | |||
| $threeDsDetail = (string) $postData['details'][$detail] ?? ''; | |||
| $threeDsDetail = (string) ($postData['details'][$detail] ?? $postData['details'][$post] ?? ''); | |||
There was a problem hiding this comment.
@acampos1916
This is BC compatible way for fetching data from web components library data,
before: underscore, new (dot).
Example: threeds2_fingerprint -> threeds2.fingerprint
peterojo
approved these changes
Jan 19, 2021
acampos1916
approved these changes
Jan 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Store payment data in DB (session has data loss)
Update 3DS2 for payment data handling
Update 3DS1 payment/details data handling parameter mismatch for request
Tested scenarios
Fixed issue: #108