AP-266 merge all payment methods in one array and filter in template #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bortefi
requested review from
acampos1916,
cyattilakiss and
msilvagarcia
as code owners
cyattilakiss
approved these changes
Feb 4, 2021
acampos1916
approved these changes
Feb 4, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Showpare 5 uses internally
array<int, array>structure to identify Payment MethodsUpdated the paymentMehtods serializer to implement SW5 list and add additional parameter for identifying stored payments.
Split up payments on selection template based on parameter.
Shipping methods are available again for enabled country and Adyen payment methods.
Shipping methods are listed below default payments.
Tested scenarios
Test cases:
Fixed issue: #124