[PW-4128] Hiding PM and Stored PM group title if the other group is empty #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acampos1916
requested review from
cyattilakiss and
msilvagarcia
as code owners
acampos1916
changed the title
cyattilakiss
approved these changes
Feb 19, 2021
peterojo
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the payment selection page Adyen lists both regular and stored payment methods with the same style as the Shopware title. In this PR an indentation is being introduced to differentiate the sections and the titles are only shown only if both groups are present.
Tested scenarios
Only stored PMs or only regular PMs: hides the title.
Both stored PMs and regular PMs are present: both titles are shown with indentation.
Fixed issue: PW-4128