PW-4139 Hide Adyen payment methods for 0 amount transactions #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterojo
requested review from
acampos1916,
cyattilakiss and
msilvagarcia
as code owners
peterojo
commented
Mar 1, 2021
| @@ -52,6 +52,8 @@ | |||
| var me = this; | |||
| if (!$.isEmptyObject(me.opts.adyenSetSession)) { | |||
| me.sessionStorage.setItem(me.paymentMethodSession, JSON.stringify(me.opts.adyenSetSession)); | |||
| } else { | |||
| me.sessionStorage.removeItem(me.paymentMethodSession); | |||
There was a problem hiding this comment.
This is necessary to clear the sessionStorage data when it is not sent from the backend, otherwise this widget might still attempt to pay with Adyen (in onPlaceOrder) and fail.
peterojo
commented
Mar 1, 2021
| { | ||
| /** @var Shopware_Controllers_Frontend_Checkout $subject */ | ||
| $subject = $args->getSubject(); |
There was a problem hiding this comment.
Instead of re-declaring the $subject in all these methods, just pass it through
cyattilakiss
reviewed
Mar 1, 2021
acampos1916
approved these changes
Mar 1, 2021
cyattilakiss
approved these changes
Mar 1, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From issue #139
This PR hides Adyen payment methods when the total amount in the basket is 0.
Resets the selected payment method to the shopware5 default when the amount has changed, e.g after applying a voucher.
Tested scenarios
Pay for item that costs nothing
Apply voucher that sets total price to 0
Fixed issue: #139