Implement needed sUniqueID for Checkout finish page #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reConNico
requested review from
acampos1916,
cyattilakiss,
msilvagarcia and
peterojo
as code owners
|
Thanks for this PR @reConNico |
acampos1916
approved these changes
Mar 22, 2021
peterojo
approved these changes
Mar 22, 2021
cyattilakiss
approved these changes
Mar 22, 2021
msilvagarcia
approved these changes
Mar 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We use Shopware 5.6.8 and had a problem that after every order the user gets correctly redirected to the checkout confirm page but with the notice that the cart is empty. The order itself and the adyen transaction works fine but the user didn't get the correct confirm page displayed.
The problem is that the Shopware Frontend Checkout Controller requires the
sUniqueIDparameter which is in the order entity in theProcessController of the adyen plugin implementation. I've just provided the parameter to the redirect and everything works as expected.Tested scenarios
Use showpare 5.6.8
Fixed issue: