Ap 235 upgrade api web components adyen library #155

bortefi · 2021-03-24T18:24:58Z

Summary

Upgrade adyen-php-library to latest version: ^10.0
- support checkout API v67
Upgrade web Components to last compatible version: 4.1.0
- included by script tag
- support checkout API v67
re-applied functionality of AP-269 keep payment after shipping selection, add update info button #151 keep payment after shipping selection, add update info button

Notes

Restricted fields send to Checkout API v67.
v67 rejects calls with data fields sent to the API (v52 allowed additional data fields set by e.g. Paypal)
Updated prop "token" for 3DS Fingerprint and Challenge web component
Updated 3DS web component:
- Updated for a unified flow with 3DS and web component
- Updated prop "token" for 3DS Fingerprint and Challenge
- Added paymentData prop used in 3DS Fingerprint and Challenge
- Both 3DS Fingerprint and Challange use -useOriginalFlow- use the new flow with clientKey
✔️ Adyen PHP api library has a new version 10 with Checkout API v67, this pull request will be updated to include this update.

Tested scenarios

✔️ gift cards
✔️ Kreditkarte: Mastercard / Visa
✔️ Kreditkarte store payment: store payment details (use Visa or Mastercard with Kreditkarte)
✔️ Kreditkarte payment with a stored payment method (use Visa or Mastercard with Kreditkarte)
✔️ BCMC default
✔️ 3DS2 default
✔️ 3DS - ChallengeShopper
✔️ 3DS - frictionless
✔️ PayPal payment
🚫 Klarna (not working as defined per v67 changelog)

Fixed issue: #61 , #62

Release 1.6.0

Release 1.7.0

Release 1.7.1

…changed props

bortefi · 2021-03-24T18:29:03Z

Resources/frontend/js/jquery.adyen-confirm-order.js

            $(me.opts.placeOrderSelector).parent().append('<div id="AdyenIdentifyShopperThreeDS2"/>');
            me.adyenCheckout
                .create('threeDS2DeviceFingerprint', {
-                    fingerprintToken: data.authentication['threeds2.fingerprintToken'],
+                    token: data.authentication['threeds2.fingerprintToken'],
+                    useOriginalFlow: true,


@acampos1916
~~The new flow would require a clientKey, so for upgrade I left the original flow active.~~
~~Should we update to the new flow with the ClientKey property for web components?~~
Web components 4.1.0 require ClientKey.

Similar for threeDS2Challenge

Resources/frontend/js/jquery.adyen-payment-selection.js

bortefi · 2021-03-24T18:31:41Z

Subscriber/CheckoutSubscriber.php

        if (!$paymentMethod->getValue('details') && !$paymentMethod->isStoredPayment()) {
-            $subject->View()->assign('sAdyenSetSession', json_encode($paymentMethod->getRawData()));


Seems this data was always set to incorrect data for Checkout API
(v52 did not mind this, v66 correctly rejects the call).

Updated to contain correct data when it was not handled by Web components.

bortefi · 2021-03-25T09:33:32Z

@acampos1916
Suzanne informed us that a new php library version 10 including Checkout API v67 support has been released.
It's best to include this upgrade as well, i will use this pull request for that, so do not merge it the develop branch just yet.

cyattilakiss · 2021-03-25T15:20:58Z

@bortefi
In case using the v67 checkout api you can remove the Controllers/Frontend/Transparent.php and the whole transparent redirect logic since the 3DS1 redirect will always be a GET redirect instead of POST. Also validating the MD and PaRes won't be necessary anymore because only a redirectResult param will be returned in the query.
This change will make the whole 3DS1 handling much easier.
You can find the checkout API release notes here
Let us know if you have any question regarding this.

bortefi · 2021-03-25T15:24:07Z

@cyattilakiss
That's great news, then we can get rid of some workarounds 👍

bortefi · 2021-04-02T15:57:10Z

@acampos1916 Upgrade is complete

Pr can be reviewed.

Utils/RequestDataFormatter.php

Components/Adyen/ApiConfigValidator.php

Controllers/Frontend/Adyen.php

Co-authored-by: Ángel Campos <[email protected]>

Co-authored-by: Attila Kiss <[email protected]>

…adyen-library # Conflicts: # Controllers/Frontend/Process.php

Controllers/Frontend/Adyen.php

…fo button'

…P-269-235-validate-both-functionality # Conflicts: # Resources/frontend/js/jquery.adyen-payment-selection.js

bortefi · 2021-04-20T11:21:36Z

@acampos1916

This pull request is updated and validated with #151 (#158 reverted the changes due to early merge)
#151 changes are re-applied and brought up to date within this pull request.

Re-evaluated payment selection for:

✔️ credit card (full payment method state)
✔️ paypal (minimal payment method state)

msilvagarcia · 2021-04-30T09:21:34Z

@bortefi thank you for adding the changes I merged earlier :)

acampos1916 and others added 7 commits December 3, 2020 16:51

Merge pull request Adyen#94 from Adyen/develop

f02b085

Release 1.6.0

Merge pull request Adyen#118 from Adyen/develop

11d0de6

Release 1.7.0

Merge pull request Adyen#130 from Adyen/develop

595b818

Release 1.7.1

AP-235 upgrade web components 3.19.0, api library 8.1

eb6b1c4

AP-235 donwgrade webcomponents compatibility for checkout API

e92696c

AP-235 adyen-php-lib: 9.0, Web components 3.23.0

ddc225c

AP-235 Update with API v66 fields restriction, update web components …

f9058c3

…changed props

bortefi requested review from acampos1916, cyattilakiss, msilvagarcia and peterojo as code owners March 24, 2021 18:24

bortefi commented Mar 24, 2021

View reviewed changes

Resources/frontend/js/jquery.adyen-payment-selection.js Show resolved Hide resolved

bortefi commented Mar 24, 2021

View reviewed changes

bortefi added 3 commits March 25, 2021 17:08

AP-235 wip replace originKeu with ClientKey

a5357a6

AP-235 Update Client configuration and validation

d603d8a

AP-235 Update 3DS flow

ce0e27a

cyattilakiss reviewed Apr 6, 2021

View reviewed changes

Utils/RequestDataFormatter.php Outdated Show resolved Hide resolved

acampos1916 reviewed Apr 12, 2021

View reviewed changes

Components/Adyen/ApiConfigValidator.php Outdated Show resolved Hide resolved

acampos1916 reviewed Apr 12, 2021

View reviewed changes

Components/Adyen/ApiConfigValidator.php Outdated Show resolved Hide resolved

acampos1916 reviewed Apr 12, 2021

View reviewed changes

Controllers/Frontend/Adyen.php Show resolved Hide resolved

bortefi and others added 3 commits April 12, 2021 14:23

Upper case ID

aa791b8

Co-authored-by: Ángel Campos <[email protected]>

Uppercase Api

6740419

Co-authored-by: Ángel Campos <[email protected]>

Removed unused parameters for payments/details

feaeffa

Co-authored-by: Attila Kiss <[email protected]>

acampos1916 mentioned this pull request Apr 19, 2021

[PW-4355] "Test credentials" not working #162

Closed

acampos1916 linked an issue Apr 19, 2021 that may be closed by this pull request

[PW-4355] "Test credentials" not working #162

Closed

bortefi added 2 commits April 19, 2021 12:08

AP-235 keep generic handle payment details action

c0d5a41

AP-235 Merge branch 'develop' into AP-235-upgrade-api-web-components-…

9348f4a

…adyen-library # Conflicts: # Controllers/Frontend/Process.php

bortefi commented Apr 19, 2021

View reviewed changes

Controllers/Frontend/Adyen.php Show resolved Hide resolved

bortefi added 2 commits April 19, 2021 14:52

AP-269 re-apply 'keep payment after shipping selection, add update in…

06c3c1f

…fo button'

Merge branch 'AP-235-upgrade-api-web-components-adyen-library' into A…

c55797e

…P-269-235-validate-both-functionality # Conflicts: # Resources/frontend/js/jquery.adyen-payment-selection.js

bortefi mentioned this pull request Apr 20, 2021

AP-269 keep payment after shipping selection, add update info button #151

Merged

msilvagarcia approved these changes Apr 30, 2021

View reviewed changes

acampos1916 self-requested a review May 27, 2021 10:34

acampos1916 approved these changes May 27, 2021

View reviewed changes

peterojo approved these changes May 27, 2021

View reviewed changes

cyattilakiss approved these changes May 27, 2021

View reviewed changes

acampos1916 merged commit cb03b94 into Adyen:develop May 28, 2021

acampos1916 linked an issue May 28, 2021 that may be closed by this pull request

Fallback to default config values #112

Closed

acampos1916 mentioned this pull request May 28, 2021

Fallback to default config values #112

Closed

This was linked to issues May 28, 2021

Alipay, Dotpay, Paypal redirect (not Express button) #64

Closed

[PW-2604] Failed 3DS1 authentication leads to address input instead of checkout page #47

Closed

acampos1916 mentioned this pull request Jun 8, 2021

Release 2.0.0 #170

Merged

bortefi deleted the AP-235-upgrade-api-web-components-adyen-library branch June 21, 2021 06:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ap 235 upgrade api web components adyen library #155

Ap 235 upgrade api web components adyen library #155

bortefi commented Mar 24, 2021 •

edited

Loading

bortefi Mar 24, 2021 •

edited

Loading

bortefi Mar 24, 2021 •

edited

Loading

bortefi commented Mar 25, 2021

cyattilakiss commented Mar 25, 2021

bortefi commented Mar 25, 2021

bortefi commented Apr 2, 2021

bortefi commented Apr 20, 2021

msilvagarcia commented Apr 30, 2021

		if (!$paymentMethod->getValue('details') && !$paymentMethod->isStoredPayment()) {
		$subject->View()->assign('sAdyenSetSession', json_encode($paymentMethod->getRawData()));

Ap 235 upgrade api web components adyen library #155

Ap 235 upgrade api web components adyen library #155

Conversation

bortefi commented Mar 24, 2021 • edited Loading

Summary

Notes

Tested scenarios

bortefi Mar 24, 2021 • edited Loading

Choose a reason for hiding this comment

bortefi Mar 24, 2021 • edited Loading

Choose a reason for hiding this comment

bortefi commented Mar 25, 2021

cyattilakiss commented Mar 25, 2021

bortefi commented Mar 25, 2021

bortefi commented Apr 2, 2021

bortefi commented Apr 20, 2021

msilvagarcia commented Apr 30, 2021

bortefi commented Mar 24, 2021 •

edited

Loading

bortefi Mar 24, 2021 •

edited

Loading

bortefi Mar 24, 2021 •

edited

Loading