Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW-5047] Handle IdentifyShopper, ChallengeShopper, Pending and RedirectShopper with the same createFromAction #175

Merged
merged 2 commits into from
Jul 14, 2021

Conversation

acampos1916
Copy link
Member

Summary

Payment methods that returned Pending and a QR code action (like bcmc_mobile/Payconiq) successfully created the component but were not mounting it so that the code could be shown. Here these result codes are being combined with the handling of IdentifyShopper, ChallengeShopper. The component will take care of the appropriate action.

Tested scenarios

Happy and unhappy flows for bcmc_mobile/Payconiq, 3DS1, 3DS2, iDeal.

Fixed issue: PW-5047

@wannevancamp
Copy link
Contributor

wannevancamp commented Jul 13, 2021

@acampos1916 , we already installed this PR. When the modal of the handlePaymentDataCreateFromAction opens. There is no possibility to cancel that flow. There is no cancel or close button in the modal. Is the intended functionality? At this point clients are stuck and try to use the browser back button which clears the basked session. When using redirects the client can cancel their payment by using the 'go back to merchant'-button.

@acampos1916
Copy link
Member Author

@acampos1916 , we already installed this PR. When the modal of the handlePaymentDataCreateFromAction opens. There is no possibility to cancel that flow. There is no cancel or close button in the modal. Is the intended functionality? At this point clients are stuck and try to use the browser back button which clears the basked session. When using redirects the client can cancel their payment by using the 'go back to merchant'-button.

Hey @wannevancamp, this PR hasn't changed that modal, only reuses it for different result codes. Was this not the behavior before deploying this PR?

@wannevancamp
Copy link
Contributor

@acampos1916 , we already installed this PR. When the modal of the handlePaymentDataCreateFromAction opens. There is no possibility to cancel that flow. There is no cancel or close button in the modal. Is the intended functionality? At this point clients are stuck and try to use the browser back button which clears the basked session. When using redirects the client can cancel their payment by using the 'go back to merchant'-button.

Hey @wannevancamp, this PR hasn't changed that modal, only reuses it for different result codes. Was this not the behavior before deploying this PR?

@acampos1916 , you are right. This PR hasn't changed the modal. When testing the integration we saw an issue with the modal. Will create a new ticket where we can discuss this behaviour.

@acampos1916
Copy link
Member Author

@wannevancamp sounds good! Thanks. Ideally we would listen for the modal close event and handle it as a regular payment failure. A new ticket would be great as it isn't exactly related to this PR 👍

@acampos1916 acampos1916 merged commit c2343d2 into develop Jul 14, 2021
@acampos1916 acampos1916 deleted the PW-5047 branch July 14, 2021 07:57
@acampos1916 acampos1916 mentioned this pull request Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants