-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PW-5047] Handle IdentifyShopper, ChallengeShopper, Pending and RedirectShopper with the same createFromAction #175
Conversation
…ectShopper with the same createFromAction
@acampos1916 , we already installed this PR. When the modal of the |
Hey @wannevancamp, this PR hasn't changed that modal, only reuses it for different result codes. Was this not the behavior before deploying this PR? |
@acampos1916 , you are right. This PR hasn't changed the modal. When testing the integration we saw an issue with the modal. Will create a new ticket where we can discuss this behaviour. |
@wannevancamp sounds good! Thanks. Ideally we would listen for the modal close event and handle it as a regular payment failure. A new ticket would be great as it isn't exactly related to this PR 👍 |
Summary
Payment methods that returned Pending and a QR code action (like bcmc_mobile/Payconiq) successfully created the component but were not mounting it so that the code could be shown. Here these result codes are being combined with the handling of IdentifyShopper, ChallengeShopper. The component will take care of the appropriate action.
Tested scenarios
Happy and unhappy flows for bcmc_mobile/Payconiq, 3DS1, 3DS2, iDeal.
Fixed issue: PW-5047