Adjusting typings for BrowserInfo #2131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Corrected typings for BrowserInfo to reflect the actual data that is being sent (https://docs.adyen.com/api-explorer/Checkout/70/post/payments#request-browserInfo) - Adds optional javaScriptEnabled field
ossiggy
requested review from
marcperez,
pabloai,
sponglord,
m1aw,
ribeiroguilherme,
jobsturm and
longyulongyu
as code owners
ossiggy
changed the title
sponglord
reviewed
May 5, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
sponglord
approved these changes
May 5, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tested scenarios
Logged
onChangeevent and the data types of each field inbrowserInfo. Confirmed that these were incorrect in the type definition of BrowserInfoFixed issue: #2078