Field comp stops using div element inside the label #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme,
jobsturm and
longyulongyu
as code owners
|
Size Change: -7 B (0%) Total Size: 1.03 MB
ℹ️ View Unchanged
|
|
Kudos, SonarCloud Quality Gate passed!
|
ribeiroguilherme
approved these changes
May 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The a11y audit gives errors about placing
divsinsidelabelelements.It seems that the HTML spec says that a
divcannot go inside alabel(which will only accept "Phrasing content").Doing so cause automated HTML validators, such as https://validator.w3.org/nu/, to throw errors.
This PR fixes this, for most cases* by using a
spanelement instead of thediv.*However components that feature select/dropdown elements e.g. issuerLists, or Address comps with country selectors, will still contain
divs(since that is how the dropdowns are built). This will need to be addressed in a future PRTested scenarios
Components without dropdowns no longer have a
divinside theirlabelelementFixed issue: partially fixes a11y issue with instanceID=2047874661