Adds ANCV payment method component #2293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1aw
commented
Aug 10, 2023
| }; | ||
| } | ||
|
|
||
| private onOrderRequest = data => { |
There was a problem hiding this comment.
This logic should be move elsewhere.
|
Size Change: +10.3 kB (+1%) Total Size: 1.08 MB
|
|
SonarCloud Quality Gate failed.
|
🦋 Changeset detectedLatest commit: fe2766f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
m1aw
requested review from
marcperez,
pabloai,
sponglord,
ribeiroguilherme and
longyulongyu
as code owners
|
Just wanted to confirm this is also working on |
sponglord
approved these changes
Oct 9, 2023
|
Don't forget to add a .changeset file |
Merged
|
SonarCloud Quality Gate failed.
|
|
Asked in PR view, but will repeat here as well: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds support for ANCV voucher await component.
This component is a mix between an await component with a gift card (partial payment method).
Payment flow is like follows:
PartiallyAuthorisedin result code fromstatusand request paymentDetails receiving anorderThe main problems with this current PR is the code duplication. Big parts of the code have been ported from giftcard without a good way to extracting the logic.
Also there's currently missing code coverage.
Tested scenarios
Fixed issue: