Klarna B2B - Fixing logo on Drop-in #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeiroguilherme
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 447cb37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +1 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
sponglord
reviewed
Dec 4, 2023
sponglord
approved these changes
Dec 4, 2023
Merged
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The logo on UIElement currently is being built using the
this.constructor[type]. This implies that it will always use the main tx variant defined in the Component, although there are components that have multiple TxVariants (for ex: Klarna, DragonPay, etc).So instead of getting the main tx variant to use as icon, we are now pulling the tx variant from the
type()getter which will decide if we take from thetypeproperty or from thethis.constructor[type].I suggest to also test this change locally, changing the country codes and validating that logos are ok
Tested scenarios
iconmethod pulls the txVariant fromtypegetter