card_stop adding credit/debit class to non-cards #2465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sponglord
requested review from
marcperez,
pabloai,
m1aw,
ribeiroguilherme and
longyulongyu
as code owners
🦋 Changeset detectedLatest commit: 1c3fe6b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Size Change: +149 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
ribeiroguilherme
approved these changes
Nov 23, 2023
sponglord
deleted the
fix/stop_adding_fundingSource_class_to_nonCards
branch
Merged
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For all
PaymentMethodItemswe were adding a classadyen-checkout__payment-method--{fundingSource}(wherefundingSourcewas either "credit" or "debit")This is meant to be a Card PM specific class to indicate, in the paymentMethods list, whether the card is a credit or debit card.
Tested scenarios
adyen-checkout__payment-method--creditno longer added to non-card PMs