Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sessionData after /setup call #2504

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

sponglord
Copy link
Contributor

@sponglord sponglord commented Jan 3, 2024

Summary

We weren't updating our internal sessionData after a new sessionData blob is returned from the /setup call.
Although the original blob remains valid, best practice says that we should always use the latest sessionData returned by the backend

Tested scenarios

A /payments call made using the sessionData returned from the /setup call, instead of the one from the original /session call, succeeds in making a payment.

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: c28c325

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

sonarcloud bot commented Jan 3, 2024

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Size Change: +2 B (0%)

Total Size: 1.1 MB

Filename Size Change
packages/lib/dist/adyen.js 292 kB +1 B (0%)
packages/lib/dist/es.modern/index.js 120 kB -1 B (0%)
packages/lib/dist/es/index.js 140 kB +2 B (0%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/cjs/index.js 252 kB
packages/lib/dist/es.modern/ar.js 6.72 kB
packages/lib/dist/es.modern/cs-CZ.js 5.98 kB
packages/lib/dist/es.modern/da-DK.js 5.41 kB
packages/lib/dist/es.modern/de-DE.js 5.86 kB
packages/lib/dist/es.modern/el-GR.js 7.64 kB
packages/lib/dist/es.modern/es-ES.js 5.51 kB
packages/lib/dist/es.modern/fi-FI.js 5.52 kB
packages/lib/dist/es.modern/fr-FR.js 5.71 kB
packages/lib/dist/es.modern/hr-HR.js 5.76 kB
packages/lib/dist/es.modern/hu-HU.js 6.02 kB
packages/lib/dist/es.modern/it-IT.js 5.59 kB
packages/lib/dist/es.modern/ja-JP.js 6.47 kB
packages/lib/dist/es.modern/ko-KR.js 6.08 kB
packages/lib/dist/es.modern/nl-NL.js 5.54 kB
packages/lib/dist/es.modern/no-NO.js 5.38 kB
packages/lib/dist/es.modern/pl-PL.js 6.06 kB
packages/lib/dist/es.modern/pt-BR.js 5.57 kB
packages/lib/dist/es.modern/pt-PT.js 5.69 kB
packages/lib/dist/es.modern/ro-RO.js 5.83 kB
packages/lib/dist/es.modern/ru-RU.js 7.13 kB
packages/lib/dist/es.modern/sk-SK.js 6.13 kB
packages/lib/dist/es.modern/sl-SI.js 5.69 kB
packages/lib/dist/es.modern/sv-SE.js 5.4 kB
packages/lib/dist/es.modern/zh-CN.js 5.9 kB
packages/lib/dist/es.modern/zh-TW.js 6.02 kB
packages/lib/dist/es/ar.js 6.72 kB
packages/lib/dist/es/cs-CZ.js 5.98 kB
packages/lib/dist/es/da-DK.js 5.41 kB
packages/lib/dist/es/de-DE.js 5.86 kB
packages/lib/dist/es/el-GR.js 7.64 kB
packages/lib/dist/es/es-ES.js 5.51 kB
packages/lib/dist/es/fi-FI.js 5.52 kB
packages/lib/dist/es/fr-FR.js 5.71 kB
packages/lib/dist/es/hr-HR.js 5.76 kB
packages/lib/dist/es/hu-HU.js 6.02 kB
packages/lib/dist/es/it-IT.js 5.59 kB
packages/lib/dist/es/ja-JP.js 6.47 kB
packages/lib/dist/es/ko-KR.js 6.08 kB
packages/lib/dist/es/nl-NL.js 5.54 kB
packages/lib/dist/es/no-NO.js 5.38 kB
packages/lib/dist/es/pl-PL.js 6.06 kB
packages/lib/dist/es/pt-BR.js 5.57 kB
packages/lib/dist/es/pt-PT.js 5.69 kB
packages/lib/dist/es/ro-RO.js 5.83 kB
packages/lib/dist/es/ru-RU.js 7.13 kB
packages/lib/dist/es/sk-SK.js 6.13 kB
packages/lib/dist/es/sl-SI.js 5.69 kB
packages/lib/dist/es/sv-SE.js 5.4 kB
packages/lib/dist/es/zh-CN.js 5.9 kB
packages/lib/dist/es/zh-TW.js 6.02 kB

compressed-size-action

@sponglord sponglord merged commit b6f2a2d into main Jan 3, 2024
10 checks passed
@sponglord sponglord deleted the feature/update_sessionData_after_setup branch January 3, 2024 16:12
@github-actions github-actions bot mentioned this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants