-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/improve QR payments status check #2506
Conversation
🦋 Changeset detectedLatest commit: dbf5339 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Change: +881 B (0%) Total Size: 1.1 MB
ℹ️ View Unchanged
|
bc10f3d
to
dbf5339
Compare
Quality Gate failedFailed conditions 79.5% Coverage on New Code (required ≥ 80%) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Summary
Issue reproduce steps:
Refactored the polling mechanism using
setTimeout
together with the recursion. With this new changes we can wait for previous call to finish before starting a new one, and are able to collect the response time hence calculate the passed time more accurately.Tested scenarios
Unit tests pass.
Fixed issue: #2499