Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always save the payment method for zero-auth payments #2571

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

longyulongyu
Copy link
Contributor

@longyulongyu longyulongyu commented Feb 22, 2024

Summary

There is a bug identified that we are not sending the storePaymentMethod to the BE for zero auth payments. Because we removed the store details checkbox for zero-auth payments in #2514, but didn't add the logic to always send the storePaymentMethod indicator.

Tested scenarios

Unit tests added.

Copy link

changeset-bot bot commented Feb 22, 2024

🦋 Changeset detected

Latest commit: 7080768

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@adyen/adyen-web Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Size Change: +180 B (0%)

Total Size: 1.13 MB

Filename Size Change
packages/lib/dist/adyen.js 298 kB +38 B (0%)
packages/lib/dist/cjs/index.js 259 kB +38 B (0%)
packages/lib/dist/es.modern/index.js 122 kB +66 B (0%)
packages/lib/dist/es/index.js 142 kB +38 B (0%)
ℹ️ View Unchanged
Filename Size
packages/lib/dist/es.modern/ar.js 6.95 kB
packages/lib/dist/es.modern/cs-CZ.js 6.19 kB
packages/lib/dist/es.modern/da-DK.js 5.62 kB
packages/lib/dist/es.modern/de-DE.js 6.09 kB
packages/lib/dist/es.modern/el-GR.js 7.91 kB
packages/lib/dist/es.modern/es-ES.js 5.73 kB
packages/lib/dist/es.modern/fi-FI.js 5.73 kB
packages/lib/dist/es.modern/fr-FR.js 5.96 kB
packages/lib/dist/es.modern/hr-HR.js 5.99 kB
packages/lib/dist/es.modern/hu-HU.js 6.27 kB
packages/lib/dist/es.modern/it-IT.js 5.81 kB
packages/lib/dist/es.modern/ja-JP.js 6.69 kB
packages/lib/dist/es.modern/ko-KR.js 6.32 kB
packages/lib/dist/es.modern/nl-NL.js 5.76 kB
packages/lib/dist/es.modern/no-NO.js 5.58 kB
packages/lib/dist/es.modern/pl-PL.js 6.27 kB
packages/lib/dist/es.modern/pt-BR.js 5.78 kB
packages/lib/dist/es.modern/pt-PT.js 5.91 kB
packages/lib/dist/es.modern/ro-RO.js 6.05 kB
packages/lib/dist/es.modern/ru-RU.js 7.39 kB
packages/lib/dist/es.modern/sk-SK.js 6.36 kB
packages/lib/dist/es.modern/sl-SI.js 5.91 kB
packages/lib/dist/es.modern/sv-SE.js 5.59 kB
packages/lib/dist/es.modern/zh-CN.js 6.13 kB
packages/lib/dist/es.modern/zh-TW.js 6.22 kB
packages/lib/dist/es/ar.js 6.95 kB
packages/lib/dist/es/cs-CZ.js 6.19 kB
packages/lib/dist/es/da-DK.js 5.62 kB
packages/lib/dist/es/de-DE.js 6.09 kB
packages/lib/dist/es/el-GR.js 7.91 kB
packages/lib/dist/es/es-ES.js 5.73 kB
packages/lib/dist/es/fi-FI.js 5.73 kB
packages/lib/dist/es/fr-FR.js 5.96 kB
packages/lib/dist/es/hr-HR.js 5.99 kB
packages/lib/dist/es/hu-HU.js 6.27 kB
packages/lib/dist/es/it-IT.js 5.81 kB
packages/lib/dist/es/ja-JP.js 6.69 kB
packages/lib/dist/es/ko-KR.js 6.32 kB
packages/lib/dist/es/nl-NL.js 5.76 kB
packages/lib/dist/es/no-NO.js 5.58 kB
packages/lib/dist/es/pl-PL.js 6.27 kB
packages/lib/dist/es/pt-BR.js 5.78 kB
packages/lib/dist/es/pt-PT.js 5.91 kB
packages/lib/dist/es/ro-RO.js 6.05 kB
packages/lib/dist/es/ru-RU.js 7.39 kB
packages/lib/dist/es/sk-SK.js 6.36 kB
packages/lib/dist/es/sl-SI.js 5.91 kB
packages/lib/dist/es/sv-SE.js 5.59 kB
packages/lib/dist/es/zh-CN.js 6.13 kB
packages/lib/dist/es/zh-TW.js 6.22 kB

compressed-size-action

Copy link

sonarcloud bot commented Feb 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@longyulongyu longyulongyu merged commit 7a1b435 into main Feb 23, 2024
9 of 10 checks passed
@longyulongyu longyulongyu deleted the fix/zero-auth-not-send-save-payment-indicator branch February 23, 2024 14:51
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants