-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropin - Filtering out unsupported payment methods before creating the payment method components #2852
Merged
ribeiroguilherme
merged 1 commit into
main
from
v6-dropin-filtering-out-pm-before-creating
Sep 13, 2024
Merged
Dropin - Filtering out unsupported payment methods before creating the payment method components #2852
ribeiroguilherme
merged 1 commit into
main
from
v6-dropin-filtering-out-pm-before-creating
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ribeiroguilherme
requested review from
marcperez,
pabloai,
sponglord,
m1aw and
longyulongyu
as code owners
September 12, 2024 13:11
🦋 Changeset detectedLatest commit: 3a38e02 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ribeiroguilherme
changed the title
Dropin - Filtering out unsupported payment method before creating it
Dropin - Filtering out unsupported payment methods before creating the payment method components
Sep 12, 2024
Size Change: +8 B (0%) Total Size: 742 kB
ℹ️ View Unchanged
|
size-limit report 📦
|
Quality Gate passedIssues Measures |
sponglord
approved these changes
Sep 12, 2024
ribeiroguilherme
deleted the
v6-dropin-filtering-out-pm-before-creating
branch
September 13, 2024 08:57
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
createElements
function was first creating the payment method element and then filtering out the non-supported ones. That was leading to the creation of the Click to Pay component, which eventually would load the 3rd party SDK's.This PR makes sure to first filter out the non-supported drop-in payment methods, to then create their payment method elements
Tested scenarios