Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds more tests to increase coverage #288

Merged
merged 38 commits into from
Oct 4, 2024
Merged

Adds more tests to increase coverage #288

merged 38 commits into from
Oct 4, 2024

Conversation

r-akemii
Copy link
Collaborator

@r-akemii r-akemii commented Jan 16, 2024 •
edited
Loading

In this PR we:

  • Removed the duplicated folder tests and moved all its tests to the main test folder (test)
  • Added .coveragerc file to configure pytest running
  • File format with Black!
  • Removed is_testing argument from tests and files
  • Added new tests:
    • test_create_examples
    • test_create_pro_file
    • test_data_layer_from_dataframe
    • test_load_dataset

Reaching 74% code coverage!

@r-akemii r-akemii marked this pull request as draft January 17, 2024 11:49
@r-akemii r-akemii marked this pull request as ready for review March 27, 2024 18:04
@pedrocamargo
Copy link
Contributor

@r-akemii , there are conflicts on this branch

@r-akemii
Copy link
Collaborator Author

@pedrocamargo we're with 67% code coverage, almost the 70% we were targeting. I'll add tests in sections with lower coverage in another PR.

pedrocamargo
pedrocamargo reviewed Oct 4, 2024
View reviewed changes
Copy link
Contributor

@pedrocamargo pedrocamargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one question there

@pedrocamargo pedrocamargo merged commit 3229abf into develop Oct 4, 2024
6 checks passed
@pedrocamargo pedrocamargo deleted the renata/adds-tests-for-common-tools branch October 4, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrocamargo pedrocamargo pedrocamargo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-akemii @pedrocamargo