Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add upgrade-15 (proposal 74) #157

Merged
merged 2 commits into from
May 26, 2024
Merged

feat: add upgrade-15 (proposal 74) #157

merged 2 commits into from
May 26, 2024

Conversation

0xpatrickdev
Copy link
Member

@0xpatrickdev 0xpatrickdev commented May 15, 2024 •
edited
Loading

mhofman
mhofman previously requested changes May 15, 2024
View reviewed changes
proposals/74:upgrade-15/package.json Outdated Show resolved Hide resolved
@mhofman mhofman dismissed their stale review May 20, 2024 20:06

Addressed

@gibson042
Copy link
Member

CI passes! 🎉

@gibson042 gibson042 requested a review from mhofman May 24, 2024 18:46
@turadg turadg marked this pull request as ready for review May 24, 2024 18:50
turadg
turadg approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@turadg turadg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Note that we don't have Mergify in this repo so the autosquash will have to be performed manually before merge

@mhofman mhofman merged commit 8cc7122 into main May 26, 2024
2 checks passed
@mhofman mhofman deleted the pc/u15 branch May 26, 2024 05:24
@turadg turadg mentioned this pull request May 27, 2024
Merged
@michaelfig michaelfig mentioned this pull request May 28, 2024
Closed
@gibson042 gibson042 mentioned this pull request May 31, 2024
Merged
mergify bot added a commit to Agoric/agoric-sdk that referenced this pull request Jun 3, 2024
@mergify
chore: Integrate on top of upgrade-15 (#9436)
440d7a8 
Fixes #9260

## Description

As of Agoric/agoric-3-proposals#157 ,
`a3p:latest` now includes results of
[upgrade-15](https://github.com/Agoric/agoric-sdk/releases/tag/agoric-upgrade-15).
This removes the duplication from the UNRELEASED upgrade handler and
a3p-integration.

### Security Considerations

n/a

### Scaling Considerations

n/a

### Documentation Considerations

n/a

### Testing Considerations

How much of the [upgrade-15
a3p-integration](https://github.com/Agoric/agoric-sdk/tree/agoric-upgrade-15/a3p-integration/proposals/a%3Aupgrade-15)
should remain in
[a:upgrade-next](https://github.com/Agoric/agoric-sdk/tree/master/a3p-integration/proposals/a%3Aupgrade-next)?
I'm thinking specifically about
[exit-reclaim.test.js](https://github.com/Agoric/agoric-sdk/blob/master/a3p-integration/proposals/a%3Aupgrade-next/exit-reclaim.test.js)
and associated preparation.

### Upgrade Considerations

@Chris-Hibbert Does
[initial.test.js](https://github.com/Agoric/agoric-sdk/blob/master/a3p-integration/proposals/a%3Aupgrade-next/initial.test.js)
needs some extension for the vaultFactory and/or scaledPriceAuthority
upgrades?
@anilhelvaci
Copy link
Contributor

anilhelvaci commented Jun 21, 2024 •
edited
Loading

CI passes! 🎉

What do you think made CI pass? @gibson042

I'm trying to get yarn test build successfully but I get the same error message as the one in this
CI run . When I look at the content of b2538ce I cannot make sense out of it as to why the changes over there made the CI pass.

What is the purpose of making a bad offer from the upgrade? (see Agoric/agoric-sdk@af9e09d)

@anilhelvaci
Copy link
Contributor

CI passes! 🎉

What do you think made CI pass? @gibson042

I'm trying to get yarn test build successfully but I get the same error message as the one in this CI run . When I look at the content of b2538ce I cannot make sense out of it as to why the changes over there made the CI pass.

What is the purpose of making a bad offer from the upgrade? (see Agoric/agoric-sdk@af9e09d)

Oh I see that checksums did not match => https://github.com/Agoric/agoric-3-proposals/actions/runs/9228100706/job/25391446982#step:10:4997. However, the latter question still remains;

What is the purpose of making a bad offer from the upgrade? (see Agoric/agoric-sdk@af9e09d)

@turadg
Copy link
Member

turadg commented Jun 21, 2024

What is the purpose of making a bad offer from the upgrade?

Because the upgrade added a repair for offers in a bad state and it needed such a state in order to confirm the upgrade worked. Agoric/agoric-sdk#9239

@anilhelvaci
Copy link
Contributor

Yeah, it makes sense now. Thanks! @turadg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibson042 gibson042 gibson042 left review comments

@turadg turadg turadg approved these changes

@mhofman mhofman Awaiting requested review from mhofman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add upgrade-15 to A3P
5 participants
@0xpatrickdev @gibson042 @anilhelvaci @turadg @mhofman