chore: fix some lint

Agoric · May 6, 2023 · 9ab9dde · 9ab9dde
1 parent 8a6672c
commit 9ab9dde
Show file tree

Hide file tree

Showing 8 changed files with 14 additions and 15 deletions.
diff --git a/packages/agoric-cli/src/commands/reserve.js b/packages/agoric-cli/src/commands/reserve.js
@@ -9,7 +9,7 @@ import { outputActionAndHint } from '../lib/wallet.js';
 
 /**
  * @param {import('anylogger').Logger} _logger
- * @param io
+ * @param {*} io
  */
 export const makeReserveCommand = (_logger, io = {}) => {
   const { stdout = process.stdout, stderr = process.stderr, now } = io;

diff --git a/packages/agoric-cli/src/lib/format.js b/packages/agoric-cli/src/lib/format.js
@@ -93,7 +93,7 @@ export const asBoardRemote = x => {
 
 /**
  * Summarize the balances array as user-facing informative tuples
-
+ *
  * @param {import('@agoric/smart-wallet/src/smartWallet').CurrentWalletRecord['purses']} purses
  * @param {AssetDescriptor[]} assets
  */

diff --git a/packages/inter-protocol/src/price/fluxAggregatorKit.js b/packages/inter-protocol/src/price/fluxAggregatorKit.js
@@ -82,7 +82,6 @@ const priceDescriptionFromQuote = quote => quote.quoteAmount.value[0];
  * @param {StorageNode} storageNode
  * @param {() => PublishKit<any>} makeDurablePublishKit
  * @param {import('@agoric/zoe/src/contractSupport/recorder.js').MakeRecorder} makeRecorder
- * @returns a method to call once to create the prepared kit
  */
 export const prepareFluxAggregatorKit = async (
   baggage,

diff --git a/packages/internal/src/callback.js b/packages/internal/src/callback.js
@@ -192,9 +192,9 @@ harden(isCallback);
 /**
  * Prepare an attenuator class whose methods can be redirected via callbacks.
  *
- * @template {{ [K in PropertyKey]: (this: any, ...args: unknown[]) => any}} Methods
+ * @template {PropertyKey} M
  * @param {import('@agoric/zone').Zone} zone The zone in which to allocate attenuators.
- * @param {(keyof Methods)[]} methodNames Methods to forward.
+ * @param {M[]} methodNames Methods to forward.
  * @param {object} opts
  * @param {InterfaceGuard} [opts.interfaceGuard] An interface guard for the
  * new attenuator.
@@ -207,7 +207,8 @@ export const prepareAttenuator = (
 ) => {
   /**
    * @typedef {(this: any, ...args: unknown[]) => any} Method
-   * @typedef {{ [K in keyof Methods]?: Callback<any> | null}} Overrides
+   * @typedef {{ [K in M]?: Callback<any> | null}} Overrides
+   * @typedef {{ [K in M]: (this: any, ...args: unknown[]) => any }} Methods
    */
   const methods = /** @type {Methods} */ (
     fromEntries(
@@ -307,7 +308,6 @@ harden(prepareAttenuator);
 /**
  * Prepare an attenuator whose methodNames are derived from the interfaceGuard.
  *
- * @template {{ [K in PropertyKey]: (this: any, ...args: unknown[]) => any}} Methods
  * @param {import('@agoric/zone').Zone} zone
  * @param {InterfaceGuard} interfaceGuard
  * @param {object} [opts]
@@ -316,8 +316,10 @@ harden(prepareAttenuator);
 export const prepareGuardedAttenuator = (zone, interfaceGuard, opts = {}) => {
   const { methodGuards } = interfaceGuard;
   const methodNames = ownKeys(methodGuards);
-  return /** @type {AttenuatorMaker<Methods>} */ (
-    prepareAttenuator(zone, methodNames, { ...opts, interfaceGuard })
-  );
+  const makeAttenuator = prepareAttenuator(zone, methodNames, {
+    ...opts,
+    interfaceGuard,
+  });
+  return /** @type {AttenuatorMaker<any>} */ (makeAttenuator);
 };
 harden(prepareGuardedAttenuator);
diff --git a/packages/smart-wallet/src/walletFactory.js b/packages/smart-wallet/src/walletFactory.js
@@ -121,7 +121,7 @@ export const makeAssetRegistry = assetPublisher => {
  * @typedef {import('@agoric/vats').NameHub} NameHub
  *
  * @typedef {{
- *   getAssetSubscription: () => ERef<Subscription<import('@agoric/vats/src/vat-bank').AssetDescriptor>>
+ *   getAssetSubscription: () => ERef<AsyncIterable<import('@agoric/vats/src/vat-bank').AssetDescriptor>>
  * }} AssetPublisher
  */
 

diff --git a/packages/vats/src/vat-bank.js b/packages/vats/src/vat-bank.js
@@ -1,5 +1,5 @@
 // @ts-check
-import { assert, Fail } from '@agoric/assert';
+import { assert } from '@agoric/assert';
 import { AmountMath, AssetKind } from '@agoric/ertp';
 import { E, Far } from '@endo/far';
 import {
@@ -186,7 +186,7 @@ const prepareBankChannelHandler = zone =>
             break;
           }
           default: {
-            // Fail`Unrecognized request ${obj && obj.type}`;
+            // Fail`Unrecognized request ${obj}`;
           }
         }
       },

diff --git a/packages/vats/src/virtual-purse.js b/packages/vats/src/virtual-purse.js
@@ -1,7 +1,6 @@
 // @ts-check
 import { M } from '@agoric/store';
 import { E } from '@endo/far';
-import { makeNotifier } from '@agoric/notifier';
 import { isPromise } from '@endo/promise-kit';
 
 import {

diff --git a/packages/vats/test/test-clientBundle.js b/packages/vats/test/test-clientBundle.js
@@ -103,7 +103,6 @@ test('connectFaucet produces payments', async t => {
                 return amt;
               },
             }),
-            // @ts-expect-error mock
             getAssetSubscription: () => null,
           }),
       }),