Merge pull request #8058 from Agoric/4620-ts-project

restore types linting

.eslintrc.cjs

@@ -36,6 +36,8 @@ module.exports = {
   parser: '@typescript-eslint/parser',
   parserOptions: lintTypes
     ? {
+        // this is not yet compatible with eslint lsp so it's conditioned on AGORIC_ESLINT_TYPES
+        EXPERIMENTAL_useProjectService: true,
         sourceType: 'module',
         project: [
           './packages/*/jsconfig.json',

golang/cosmos/package.json

@@ -19,7 +19,7 @@
     "postpack": "git clean -f git-revision.txt",
     "build": "exit 0",
     "lint-fix": "yarn lint:eslint --fix",
-    "lint": "eslint '**/*.{cjs,js}'"
+    "lint": "exit 0"
   },
   "dependencies": {
     "bindings": "^1.2.1",

package.json

@@ -14,8 +14,8 @@
     "@jessie.js/eslint-plugin": "^0.4.0",
     "@types/express": "^4.17.17",
     "@types/node": "^16.13.0",
-    "@typescript-eslint/eslint-plugin": "^5.61.0",
-    "@typescript-eslint/parser": "^5.61.0",
+    "@typescript-eslint/eslint-plugin": "^6.1.0",
+    "@typescript-eslint/parser": "^6.1.0",
     "ava": "^5.3.0",
     "c8": "^7.13.0",
     "conventional-changelog-conventionalcommits": "^4.6.0",

packages/ERTP/jsconfig.json

@@ -2,6 +2,7 @@
 {
   "extends": "../../tsconfig.json",
   "include": [
+    "exported.js",
     "src/**/*.js",
     "src/**/*.ts",
     "test"

packages/SwingSet/jsconfig.json

@@ -2,10 +2,13 @@
 {
   "extends": "../../tsconfig.json",
   "include": [
+    "exported.js",
+    "demo/**/*.js",
     "lib/**/*.js",
+    "misc-tools/**/*.js",
     "src/**/*.js",
     "src/**/*.ts",
-    // "test",
+    "test",
     "tools",
-  ],
+  ]
 }

packages/SwingSet/misc-tools/db-delete.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+// @ts-nocheck
 import '@endo/init';
 import process from 'process';
 import { openSwingStore } from '@agoric/swing-store';

packages/SwingSet/misc-tools/db-dump.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* eslint-disable */
 import '@endo/init';
 import process from 'process';

packages/SwingSet/misc-tools/db-get.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+// @ts-nocheck
 import '@endo/init';
 import process from 'process';
 import { openSwingStore } from '@agoric/swing-store';

packages/SwingSet/misc-tools/db-set.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+// @ts-nocheck
 import '@endo/init';
 import process from 'process';
 import { openSwingStore } from '@agoric/swing-store';

packages/SwingSet/misc-tools/extract-contract-from-transcript.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import fs from 'fs';
 import zlib from 'zlib';
 import readline from 'readline';

packages/SwingSet/misc-tools/extract-transcript-from-kerneldb.js

@@ -1,4 +1,4 @@
-// @ts-check
+// @ts-nocheck
 
 import '@endo/init';
 import process from 'process';

packages/SwingSet/misc-tools/extract-transcript-from-slogfile.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import fs from 'fs';
 import zlib from 'zlib';
 import readline from 'readline';

packages/SwingSet/misc-tools/extract-vat-from-transcript.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import fs from 'fs';
 import zlib from 'zlib';
 import readline from 'readline';

packages/SwingSet/misc-tools/extract-xs-snapshot.js

@@ -1,4 +1,4 @@
-// @ts-check
+// @ts-nocheck
 
 import '@endo/init';
 import process from 'process';

packages/SwingSet/misc-tools/ingest-xs-snapshot.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* eslint-disable */
 // import '@endo/init';
 // import { E } from '@endo/far';

packages/SwingSet/misc-tools/measure-metering/measure.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // run as `node tools/measure-metering/measure.js`
 
 // eslint-disable-next-line import/order

packages/SwingSet/misc-tools/measure-metering/measurement-bootstrap.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* eslint-disable import/no-extraneous-dependencies,no-unused-vars,no-empty-function */
 import { Far, E } from '@endo/far';
 import vaultFactoryBundle from '@agoric/inter-protocol/bundles/bundle-vaultFactory.js';

packages/SwingSet/misc-tools/measure-metering/measurement-target.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* eslint-disable import/no-extraneous-dependencies,no-unused-vars,no-empty-function */
 import { Far } from '@endo/far';
 // XXX cyclic dependency; TODO move this tool out of swingset-vat

packages/SwingSet/misc-tools/replace-bundle.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+// @ts-nocheck
 
 import '@endo/init';
 import process from 'process';

packages/SwingSet/misc-tools/replay-transcript.js

@@ -332,13 +332,15 @@ async function replay(transcriptFile) {
     throw Error(`unhandled worker type ${worker}`);
   }
 
+  // @ts-expect-error missing symbol
   /** @type {Partial<Record<ReturnType<typeof getResultKind>, Map<string, number[]>>>} */
   let syscallResults = {};
 
   const analyzeSyscallResults = () => {
     const numWorkers = workers.length;
     let divergent = false;
     for (const [kind, kindSummary] of Object.entries(syscallResults)) {
+      // @ts-expect-error due to missing symbol above, but also `syscallResults` is never populated
       for (const [syscallKey, workerList] of kindSummary.entries()) {
         if (workerList.length !== numWorkers) {
           console.error(

packages/SwingSet/misc-tools/vat-stats.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* eslint-disable */
 import '@endo/init';
 import process from 'process';

packages/SwingSet/package.json

@@ -23,7 +23,8 @@
   "devDependencies": {
     "@types/better-sqlite3": "^7.5.0",
     "@types/microtime": "^2.1.0",
-    "@types/tmp": "^0.2.0"
+    "@types/tmp": "^0.2.0",
+    "@types/yargs-parser": "^21.0.0"
   },
   "dependencies": {
     "@agoric/assert": "^0.6.0",

packages/SwingSet/test/bundling/nonvat-importable.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* global big globalThis */
 
 export function runTheCheck(world) {

packages/SwingSet/test/bundling/nonvat-install.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* global big globalThis */
 
 export function runTheCheck(world) {

packages/SwingSet/test/bundling/test-bundles-controller.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/bundling/test-bundles.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/change-parameters/test-change-parameters.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/commsVatDriver.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { assert, Fail } from '@agoric/assert';
 import buildCommsDispatch from '../src/vats/comms/index.js';
 import { debugState } from '../src/vats/comms/dispatch.js';

packages/SwingSet/test/device-hooks/test-device-hooks.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* eslint-disable no-lone-blocks */
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';

packages/SwingSet/test/device-mailbox/test-device-mailbox.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';
 // eslint-disable-next-line import/order

packages/SwingSet/test/device-plugin/test-device.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { test } from '../../tools/prepare-test-env-ava.js';
 
 // eslint-disable-next-line import/order

packages/SwingSet/test/devices/bootstrap-raw.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { Far } from '@endo/far';
 import { makePromiseKit } from '@endo/promise-kit';
 

packages/SwingSet/test/devices/test-devices.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/devices/test-raw-device.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/gc/bootstrap.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { Far, E } from '@endo/far';
 
 export function buildRootObject() {

packages/SwingSet/test/metering/test-dynamic-vat-metered.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/promise-watcher/vat-upton.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { Far, E } from '@endo/far';
 import { initEmpty } from '@agoric/store';
 import { makePromiseKit } from '@endo/promise-kit';

packages/SwingSet/test/run-policy/test-run-policy.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { test } from '../../tools/prepare-test-env-ava.js';
 
 // eslint-disable-next-line import/order

packages/SwingSet/test/test-abandon-export.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* eslint-disable import/order */
 import { test } from '../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/test-activityhash-vs-start.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/test-clist.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { test } from '../tools/prepare-test-env-ava.js';
 
 // eslint-disable-next-line import/order

packages/SwingSet/test/test-comms.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/test-controller.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/test-device-bridge.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { test } from '../tools/prepare-test-env-ava.js';
 
 // eslint-disable-next-line import/order

packages/SwingSet/test/test-gc-and-finalize.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* global FinalizationRegistry WeakRef */
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';

packages/SwingSet/test/test-gc-kernel.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* global WeakRef, FinalizationRegistry */
 // eslint-disable-next-line import/order
 import anylogger from 'anylogger';

packages/SwingSet/test/test-kernel.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/test-message-patterns-comms.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* eslint no-await-in-loop: "off" */
 /* eslint dot-notation: "off" */
 /* eslint object-shorthand: "off" */

packages/SwingSet/test/test-message-patterns-local.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* eslint no-await-in-loop: "off" */
 /* eslint dot-notation: "off" */
 /* eslint object-shorthand: "off" */

packages/SwingSet/test/test-network.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/test-promises.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { test } from '../tools/prepare-test-env-ava.js';
 
 // eslint-disable-next-line import/order

packages/SwingSet/test/test-state.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* eslint-disable no-useless-concat */
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';

packages/SwingSet/test/test-syscall-failure.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { test } from '../tools/prepare-test-env-ava.js';
 
 // eslint-disable-next-line import/order

packages/SwingSet/test/test-timer-device.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { test } from '../tools/prepare-test-env-ava.js';
 
 // eslint-disable-next-line import/order

packages/SwingSet/test/test-transcript-light.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';
 // eslint-disable-next-line import/order

packages/SwingSet/test/test-vat-env.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import { test, VatData } from '../tools/prepare-test-env-ava.js';
 
 // eslint-disable-next-line import/order

packages/SwingSet/test/test-vat-timer.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/test-vpid-kernel.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* global WeakRef, FinalizationRegistry */
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';

packages/SwingSet/test/test-xsnap-metering.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/test-xsnap-store.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 /* global globalThis */
 import '@endo/init/debug.js';
 

packages/SwingSet/test/timer-device/device-timer.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import setup from '../../src/devices/timer/device-timer.js';
 
 export { setup };

packages/SwingSet/test/transcript/test-state-sync-reload.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import test from 'ava';
 import '@endo/init/debug.js';
 import tmp from 'tmp';

packages/SwingSet/test/transcript/test-transcript-entries.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 import test from 'ava';
 import '@endo/init/debug.js';
 import { initSwingStore } from '@agoric/swing-store';

packages/SwingSet/test/upgrade/test-upgrade-replay.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/upgrade/test-upgrade.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';
 

packages/SwingSet/test/vat-admin/broken-module-vat.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line no-undef
 missing({});
 

packages/SwingSet/test/vat-admin/broken-root-vat.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 export function buildRootObject() {
   // eslint-disable-next-line no-undef
   return missing({});

packages/SwingSet/test/vat-admin/terminate/test-terminate-replay.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../../tools/prepare-test-env-ava.js';
 // eslint-disable-next-line import/order

packages/SwingSet/test/vat-admin/terminate/test-terminate.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../../tools/prepare-test-env-ava.js';
 // eslint-disable-next-line import/order

packages/SwingSet/test/vat-admin/test-create-vat.js

@@ -1,3 +1,4 @@
+// @ts-nocheck
 // eslint-disable-next-line import/order
 import { test } from '../../tools/prepare-test-env-ava.js';
 // eslint-disable-next-line import/order