Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feePurse arg to Zoe methods. Also partially apply the feePurse to produce original Zoe API #3322

Closed
katelynsills opened this issue Jun 15, 2021 · 1 comment
Assignees
Labels
Zoe package: Zoe

Comments

@katelynsills
Copy link
Contributor

katelynsills commented Jun 15, 2021

As part of #3294, we should add the feePurse to be used for paying for execution, to Zoe methods. We can separate this task from the actual charging of the feePurse. In effect, feePurses are required, but all calls are still free.

If we assume a lower-level stamp model (see #3294) that reduces spam generally, the only methods that require a feePurse are:

    install,
    startInstance,
    offer,
    getPublicFacet

And the following are queries that only require a stamp and no charge:

    getInvitationIssuer,
    getBrands,
    getIssuers,
    getTerms,
    getInstance,
    getInstallation,
    getInvitationDetails,

makeFeePurse is not a query, but it's also no charge because to charge a fee for making a feePurse wouldn't be very sensical.

As part of this task, we should provide a version of Zoe that has the original API, with the feePurse partially applied. This will allow us to retain the old tests mostly unchanged, which lightens the load significantly.

@katelynsills katelynsills added the Zoe package: Zoe label Jun 15, 2021
@katelynsills katelynsills self-assigned this Jun 15, 2021
@rowgraus rowgraus added this to the Testnet: Metering Phase milestone Jul 23, 2021
@katelynsills katelynsills changed the title Add chargeAccount arg to Zoe methods. Also partially apply the chargeAccount to produce original Zoe API Add feePurse arg to Zoe methods. Also partially apply the feePurse to produce original Zoe API Aug 10, 2021
@katelynsills
Copy link
Contributor Author

Closed in #3319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

No branches or pull requests

2 participants