Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change select Zoe methods to take a feePurse #3663

Merged
merged 11 commits into from
Aug 14, 2021

Conversation

katelynsills
Copy link
Contributor

@katelynsills katelynsills commented Aug 11, 2021

Changes select Zoe methods to take a feePurse. Provides a function to apply a fee purse to Zoe to get the original "ZoeService" API.

Closes #3322

Stacked on #3652

packages/zoe/src/contracts/loan/lend.js Outdated Show resolved Hide resolved
packages/zoe/src/applyFeePurse.js Outdated Show resolved Hide resolved
Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried an experiment in #3675

Seems successful enough to consider for revising this PR.

Copy link
Member

@erights erights left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@katelynsills katelynsills merged commit 07f35e2 into 3294-zoe-metering Aug 14, 2021
@katelynsills katelynsills deleted the 3322-add-fee-zoe-methods branch August 14, 2021 01:43
katelynsills added a commit that referenced this pull request Aug 14, 2021
* chore: change Zoe methods to require a fee purse

Co-authored-by: Mark S. Miller <[email protected]>
katelynsills added a commit that referenced this pull request Aug 14, 2021
* chore: change Zoe methods to require a fee purse

Co-authored-by: Mark S. Miller <[email protected]>
michaelfig pushed a commit that referenced this pull request Aug 16, 2021
* chore: change Zoe methods to require a fee purse

Co-authored-by: Mark S. Miller <[email protected]>
michaelfig pushed a commit that referenced this pull request Aug 17, 2021
* chore: change Zoe methods to require a fee purse

Co-authored-by: Mark S. Miller <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants