-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type checker in IDE and CLI/CI sometimes disagree #4620
Comments
Since we've made progress on removing |
Unfortunately it's still a problem. #6575 changes the Sampling,
They could probably all be solved with some additional typing work. If we did that, we still wouldn't have the "Expected behavior" ,
…because more could pop up until we solve this structurally with #4560 |
We can fix this with typescript-eslint/typescript-eslint#6754 It will probably make CI run faster too and may solve #5788 |
Describe the bug
Presently, successful type checking depends on a
--maxNodeModulesJsDepth
flag which IDE use doesn't support. In some cases,@ts-expect-error
can't be used because the IDE and CLI/CI disagree about the set of errors.Expected behavior
Set of errors reported by type checker is consistent no matter where it's run.
Additional context
#4560 will fix that but that's a work item and this ticket is the bug itself. Easier to find by title search and more clear when linked to from code as to why. When that's resolved it would be good to find the
ts-ignore
we resorted to and replace them withts-expect-error
where possible. I'm assigning this to myself to take care of that.The text was updated successfully, but these errors were encountered: